Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate RGlass recipe for autolathe and ore processor #33876

Merged

Conversation

Tayrtahn
Copy link
Member

About the PR

Splits the reinforced glass lathe recipe into two separate recipes - one made with raw materials at the ore processor, and one made with glass and steel sheets at an autolathe.

Why / Balance

Fixes #32206

Technical details

YAML changes.
Renames the current RGlass latheRecipe to SheetRGlassRaw. Assigns it to the ore processor.
Adds a new latheRecipe, SheetRGlass, which has the old (pre-#32069) recipe using Steel and Glass. Assigns it to the autolathe.

See #33868 for a test to avoid this happening in the future.

Media

Autolathe:
Screenshot 2024-12-15 at 2 28 50 PM

Ore processor:
Screenshot 2024-12-15 at 2 29 22 PM

Requirements

Breaking changes

Changelog

Nah.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 15, 2024
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix!

@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Dec 15, 2024
@slarticodefast slarticodefast self-assigned this Dec 15, 2024
@slarticodefast slarticodefast merged commit 5958801 into space-wizards:master Dec 15, 2024
14 checks passed
@Tayrtahn Tayrtahn deleted the fix-lathe-rglass-uncraftable branch December 15, 2024 21:13
Doctor-Cpu pushed a commit to Doctor-Cpu/space-station-14 that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reinforced glass can't me made on autolathe
2 participants