Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amber Station - Added Holopads, Atmos Monitoring, and Advanced SMESes #33923

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

southbridge-fur
Copy link
Contributor

@southbridge-fur southbridge-fur commented Dec 18, 2024

About the PR

Holopads, atmos monitoring, and Advanced SMESes are now in master, this adds them to Amber Station.

Holopads have been spread around the map to various areas. I tried to give one to each department plus one to every major job. The clown has a holopad board so they (or the mime) can build an art installation with it if they want. There is a public holopad in the library, to help incentivize people to go to the library. Every head gets one in their room, and I've tried to name the pads in such a way that they stay neatly organized in the call list.

I already had the atmos monitoring devices in my previous PR but didn't realize I needed to also have the console. I've added the console to atmos, the bridge, and the evac shuttle.

Also the advanced SMESes were added moments ago, so I've added them too.

Also addressed some issues:

  • Fixed the fact that the bartender can't close all their shutters. I realized that the TV blocked the shutter so I removed that shutter and put a directional window there instead.
  • Gave the fake nuke disk a funny description that makes it more obvious it's the fake.
  • Generally fixed up some areas that could use screens, fire extinguishers, and other wall-ornaments.

Why / Balance

New features that need to be mapped have been mapped!

Technical details

Media

Atmos network monitor
image

Holopads!
image

Advanced SMESes
image

Bartender shutters
image

Fake nuke disk
image

Requirements

Breaking changes

Changelog

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • amber.yml

Maps are being rendered. This comment will be updated if rendering them is done.
12/18/24 02:19

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines. labels Dec 18, 2024
@southbridge-fur
Copy link
Contributor Author

Addresses #33916

@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P1: High Priority: Higher priority than other items, but isn't an emergency. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Mapping Area: Maps, or tools used for mapping labels Dec 18, 2024
@southbridge-fur
Copy link
Contributor Author

test fail real

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • amber.yml

Maps are being rendered. This comment will be updated if rendering them is done.
12/18/24 02:52

@github-actions github-actions bot added the size/L Denotes a PR that changes 1000-4999 lines. label Dec 18, 2024
@southbridge-fur southbridge-fur changed the title Amber Station - Added Holopads and Atmos Monitoring Amber Station - Added Holopads, Atmos Monitoring, and Advanced SMESes Dec 18, 2024
@southbridge-fur
Copy link
Contributor Author

I don't know what's wrong. I don't have any serialized invalids.

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • amber.yml

Maps are being rendered. This comment will be updated if rendering them is done.
12/18/24 03:32

@ArtisticRoomba
Copy link
Contributor

Heya. The Advanced SMESes and AME power curve PRs work with the larger goal of enabling stations to conform with the current legacy engineering design document. In short:

  • At 5 minutes, the AME is turned on. The battery levels on your primary SMES bank should be close to or above 30% at this time.
  • At 10 minutes, the solars are presumed to have been setup. The battery levels should now be around 20%.
  • At 15 minutes, battery levels can drop nearing 20-10%.
  • At 20 minutes, a major power source is assumed to have started. The batteries shouldn't be dead at this point.

If you could make sure your map conforms to this with the advanced SMES changes, that would really help engineering.

image

@Pumkin69
Copy link

great work you are doing a wonderful job <3

@southbridge-fur
Copy link
Contributor Author

Heya. The Advanced SMESes and AME power curve PRs work with the larger goal of enabling stations to conform with the current legacy engineering design document.

I can check yeah

@ArtisticRoomba
Copy link
Contributor

Failed GameMapsLoadableTest("Amber") [8 s]
  Error Message:
   SERVER: 7.999s [ERRO] map: Error in map file: found local entity UID '0' which does not exist.

Might have invalids.

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • amber.yml

Maps are being rendered. This comment will be updated if rendering them is done.
12/18/24 04:24

@Emisse Emisse merged commit 122e307 into space-wizards:master Dec 18, 2024
12 checks passed
@southbridge-fur southbridge-fur deleted the amber-stable-features branch January 8, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: Bugfix Type: Bugs and/or bugfixes T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants