Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bagel Power Rebalance + Gas Pipe Sensors #33925

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Bagel Power Rebalance + Gas Pipe Sensors #33925

merged 3 commits into from
Dec 18, 2024

Conversation

ArtisticRoomba
Copy link
Contributor

About the PR

Rebalances bagel power to be more in-line with the current engineering design document.

Adds gas pipe sensors.

Why / Balance

All stations currently don't match up with the power flow we want. This PR addresses that. Now, engineering has more time on their hands to teach TAs, and just setup power in general.

Media

Bagel-0

Highlighted Changes Media

Content Client_TWmOgoScY8
Content Client_U40ln0n0jC

Requirements

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • bagel.yml

Maps are being rendered. This comment will be updated if rendering them is done.
12/18/24 04:15

@github-actions github-actions bot added size/XL Denotes a PR that changes 5000+ lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 18, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Mapping Area: Maps, or tools used for mapping labels Dec 18, 2024
@ArtisticRoomba
Copy link
Contributor Author

This works towards #33916 and #33903.

@Emisse Emisse merged commit 91b85be into space-wizards:master Dec 18, 2024
14 checks passed
@ArtisticRoomba ArtisticRoomba deleted the bagel-power-fix branch December 19, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XL Denotes a PR that changes 5000+ lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtisticRoomba @Emisse @beck-thompson