Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holopad prototypes for mapping #33931

Merged

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Dec 18, 2024

About the PR

Added holopad prototypes to use in mapping
Keep in mind not ALL of those have to be mapped in each map

Why / Balance

So translators dont have to remap every single map

Technical details

Full list:

General:
General - Tools
General - Cryosleep
General - Theater
General - Disposals
General - EVA Storage
General - Lounge
General - Arcade
General - Evac
General - Arrivals

Command:
Command - Bridge
Command - Vault
Command - Bridge Hallway
Command - Meeting Room
Command - Lounge
Command - Captain
Command - HoP
Command - CMO
Command - QM
Command - CE
Command - RD
Command - HoS

Science:
Science - Anomaly
Science - Artifact
Science - Robotics
Science - R&D
Science - Front
Science - Breakroom

Medical:
Medical - Medbay
Medical - Chemistry
Medical - Cryopods
Medical - Morgue
Medical - Surgery
Medical - Paramedic
Medical - Virology
Medical - Front
Medical - Breakroom

Cargo:
Cargo - Front
Cargo - Cargo Bay
Cargo - Salvage Bay
Cargo - Breakroom
Cargo - ATS (long range)
Cargo - Shuttle (long range)

Engineering:
Atmos - Front
Atmos - Main
Atmos - TEG
Engineering - Storage
Engineering - Breakroom
Engineering - Front
Engineering - Telecoms
Engineering - Tech Vault

Security:
Security - Front
Security - Brig
Security - Warden
Security - Interrogation
Security - Breakroom
Security - Detective
Security - Perma
Security - Courtroom
Security - Lawyer
Security - Armory

Service:
Service - Janitor
Service - Bar
Service - Kitchen
Service - Botany
Service - Chapel
Service - Library
Service - Newsroom
Service - Zookeeper
Service - Boxer
Service - Clown
Service - Mime
Service - Musician

AI:
AI - Core
AI - Main
AI - Upload
AI - Backup Power
AI - Entrance
AI - Chute

Misc:
Station - Bridge (long range)
Station - Cargo Bay (long range)
CentComm - Evacuation Shuttle (long range)

Media

None

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Dec 18, 2024
@ScarKy0 ScarKy0 added P1: High Priority: Higher priority than other items, but isn't an emergency. T: New Feature Type: New feature or content, or extending existing content T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Mapping Area: Maps, or tools used for mapping and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 18, 2024
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me except that one concern I had.

Copy link
Contributor

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are not localized and only way to fix it is to create a locale string for each of them

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Dec 18, 2024

they are not localized and only way to fix it is to create a locale string for each of them

Not possible unless chromiumboy adds a way to rename them. Currently theyre done with labels and that can be easily done by changing them in Resources (Still better than every holopad having its own weird way of being named, and this is easier to fix once we do get locale strings)

@lzk228
Copy link
Contributor

lzk228 commented Dec 18, 2024

but labelcomponent does support locale strings

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Dec 18, 2024

but labelcomponent does support locale strings

IT DOES???
Well shit
I will fix it soon, if those get merged they can at least be mapped bc no ID will change anymore

Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea looks good to me

@ScarKy0 ScarKy0 requested a review from lzk228 December 18, 2024 11:15
@ScarKy0 ScarKy0 added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Dec 18, 2024
@slarticodefast slarticodefast merged commit 87f39af into space-wizards:master Dec 18, 2024
13 checks passed
@slarticodefast slarticodefast mentioned this pull request Dec 18, 2024
14 tasks
@ScarKy0 ScarKy0 deleted the mapping-holopad-prototypes branch December 20, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants