-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holopad prototypes for mapping #33931
Holopad prototypes for mapping #33931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me except that one concern I had.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are not localized and only way to fix it is to create a locale string for each of them
Not possible unless chromiumboy adds a way to rename them. Currently theyre done with labels and that can be easily done by changing them in Resources (Still better than every holopad having its own weird way of being named, and this is easier to fix once we do get locale strings) |
but labelcomponent does support locale strings |
IT DOES??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea looks good to me
About the PR
Added holopad prototypes to use in mapping
Keep in mind not ALL of those have to be mapped in each map
Why / Balance
So translators dont have to remap every single map
Technical details
Full list:
Media
None
Requirements
Breaking changes
Changelog