Disable footstep sounds for ghosts #343

Moneyl · 2019-09-17T01:32:18Z

Adds a check before playing footstep sounds to check if the mover is a ghost. Doesn't play footstep sounds if they are a ghost.

Fixes #218

Adds a check before playing footstep sounds to check if the mover is a ghost. Doesn't play footstep sounds if they are a ghost.

PJB3005 · 2019-09-18T20:06:28Z

Content.Server/GameObjects/EntitySystems/MoverSystem.cs

@@ -153,6 +153,12 @@ private void UpdateKinematics(ITransformComponent transform, IMoverComponent mov
                if (mover.StepSoundDistance > distanceNeeded)
                {
                    mover.StepSoundDistance = 0;
+
+                    if (mover.Owner.Prototype.ID == "MobObserver" || mover.Owner.Prototype.ID == "AdminObserver")


This should absolutely be done by checking for the existence of a component.

Make a component that makes something make footstep sounds and add it to humans.

Added FootstepSoundComponent. It's just an empty component that's checked for in MoverSystem.cs instead of checking the prototype names. Figured I'd start with that simple approach, but if you wanted it to do more lemme know.

Nah, that's perfect.

Adds FootstepSoundComponent. If a mob has this component, it will make footstep sounds. Otherwise they will not. As of this commit humans have this component and ghosts do not.

Atlas update

* Update admin-announce-window.ftl * Update options-menu.ftl * Update generic.ftl * Update ghost-role-component.ftl * Update lathe-menu.ftl * Update lathe-queue-menu.ftl * Update receiver_ports.ftl * Update cloning-console-component.ftl * Update health-analyzer-component.ftl * Update toxins.ftl * Update containment-component.ftl * Update regalrat.ftl * Update computer.ftl * Update computers.ftl * Update health-analyzer-component.ftl * Update medical-scanner-component.ftl * Delete lathequeue-menu.ftl * Delete cloning-pod-component.ftl * Update research-console-component.ftl * Update research-client-component.ftl * Update configuration-component.ftl * Update conveyor-component.ftl * Update fire-extinguisher-component.ftl * Update flash-component.ftl * Update gravity-generator-component.ftl * Update guardian.ftl * Update lock-component.ftl * Update main-menu.ftl * Update gamemap.ftl * Update crew-monitoring-component.ftl * Update suit-sensor-component.ftl * Update crematorium-entity-storage-component.ftl * Update morgue-entity-storage-component.ftl * Update die-condition.ftl * Update kill-person-condition.ftl * Update other-traitor-alive-condition.ftl * Update steal-condition.ftl * Update pai-system.ftl * Update paper-component.ftl * Update pneumatic-cannon-component.ftl * Update power-cell-slot-component.ftl * Update power-receiver-component.ftl * Update humanoid-profile-editor.ftl * Update rcd-ammo-component.ftl * Update rcd-component.ftl * Update resist-locker-component.ftl * Update ai-actions.ftl * Update rotatable-component.ftl * Update dice.ftl * Update tools.ftl * Update stack-component.ftl * Update sticky-component.ftl * Update welder-component.ftl * Update uplink-component.ftl * Update actionmenu.ftl * Update timer-trigger.ftl * Update wieldable-component.ftl * Update window-component.ftl * Update mime.ftl * Update accents.ftl * Update agent-id-card-component.ftl * Update human-hair.ftl * Update blocking.ftl * Update combat-mode.ftl * Update disarm-action.ftl * Update dragon.ftl * Update pai.ftl * Update discount.ftl * Update udder-system.ftl * Update blockgame.ftl * Update spacevillain.ftl * Update plant-holder-component.ftl * Update bible.ftl * Update chem-master-component.ftl * Update climbable-component.ftl * Update toggleable-clothing-component.ftl * Update storage-component.ftl * Update construction-system.ftl * Update crayon-component.ftl * Update cuffable-component.ftl * Update detail-examinable.ftl * Update dice-component.ftl * Update diagnoser.ftl * Update diagnoser.ftl * Update scanner.ftl * Update drone-system.ftl * Update electrocuted-component.ftl * Update spillable-component.ftl * Update spray-component.ftl * Update microwave-component.ftl * Update light-replacer-component.ftl * Update blockgame.ftl * Update crayon-component.ftl * Update lock-component.ftl * Update stack-component.ftl * Update pai-system.ftl * Update crayon-component.ftl

* decal touchup

* Drinks cartons return * Fix * apple juice update * sprite update * updete * big update интересный факт пока я делал этот коминт у меня пк крашнул 5 раз :catdespair: * Big juce update * fix * Update juice * Meh * Weh * Wut --------- Co-authored-by: MilenVolf <milen.volf@gmail.com>

…l-Groups Localize X-01 Steal Goal

@deltanedas

* Fix double label on chem jugs (space-wizards#29137) * Automatic changelog update * Fix DresserFilled storagefill rarely causing an error (space-wizards#29135) Add ClothingUniformJumpskirtColorPink to an OrGroup * Fix female reptilians not having gasp sounds (space-wizards#29143) inital * clean up weather systems (space-wizards#28792) * clean up weather systems * Update WeatherComponent.cs * Update SharedWeatherSystem.cs * some fix * Update SharedWeatherSystem.cs * Update WeatherComponent.cs * Update WeatherComponent.cs * revert autoPause * Update SharedWeatherSystem.cs * Implement vital chef's hat functionality (space-wizards#25950) * Implement crucial chef's hat functionality * Unified stopping code and added events. * Added documentation to events * Rerun tests * Made review changes, and fixed potential desync bug. * Update whitelist * Automatic changelog update * Add cvar to disable round end pvs overrides (space-wizards#29151) * Update submodule to 226.1.0 (space-wizards#29159) * Fix conveyor mispredicts (space-wizards#28157) * Fix conveyor mispredicts Instead of tracking active conveyors we instead track the conveyed entities. This also handles things like stacking conveyors more gracely. * Fix ActiveConveyor * Fix lerping * Automatic changelog update * Replace StationRandomTransform (space-wizards#29149) * Revert "Rotate and Offset station CCVar nuke (space-wizards#26175)" This reverts commit 44b20f6. # Conflicts: # Content.Server/Station/Systems/StationSystem.cs # Resources/Prototypes/Maps/europa.yml * Fix * Review * Add warning cones to engivend (space-wizards#29085) Add cones to engivend * Automatic changelog update * arachnid inventory layout fix (space-wizards#29165) arachnid inventory layout fixC * Automatic changelog update * Turn interaction related attempt events into structs (space-wizards#29168) * Turn InteractionAttemptEvent into a struct event * readonly * GettingInteractedWithAttemptEvent * ConsciousAttemptEvent * Add the most anticipated gun in the game. Foam Force. (space-wizards#29103) * Foam Force * make it available somewhere * add clumsyproof and nuke dev item * reorganize * oopsy files * Strap! * woopsie layering * fix grammar to rerun tests for rogue unrelated test fail. * cleanup * I eepy layer forgetti spaghetti * For real last necessary commit * Oops I broke the law! feexed * Decided to just change it to the same source as the poster source in our repo for consistency. * Automatic changelog update * Fix material storage going BRRT (space-wizards#29167) If the volume hits 0 we just remove it. * Automatic changelog update * Fix air alarms (space-wizards#29172) Broken by space-wizards#28272 * Automatic changelog update * Hidden loadout groups (space-wizards#29170) * loadout hiding * department of redundancy department * Upgrade rsi-diff's changed files action | Make it only return rsi and png changes (space-wizards#29185) It was brought up to me in space-wizards#29179 (comment) (and from a dm from them) that space bars can cause issues with the rsi bot. Upon investigation its case we use "space-delimited" on the "get changes files" check. Which returns ALL changed files. Even if the change has nothing to do with png's or rsi's (example a downstream merging upstream) * unhardcode thief MaxSelectedSets (space-wizards#29175) * unhardcode thief MaxSelectedSets * we do a little copy paste

*

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * PullingController cooldown change (space-wizards#29177) * Revert "Automatic changelog update" This reverts commit 3358aef. * Revert "Revert "Automatic changelog update"" This reverts commit 3d0b6a7. * Removal of the throw cooldown as it felt sluggish and unresponsive before. * Decrease meteor frequency (space-wizards#29194) * Automatic changelog update * Security Resprite (space-wizards#29082) * security resprite * hos cap fix * i forgor * further fixes * my furniture is broken * fedora update * Automatic changelog update * Make Hamlet a valid chef's hat pilot (space-wizards#29191) * Fix Underwing wings (space-wizards#29092) * add * tweak thickness of stripe * Add some happier medibot messages! (space-wizards#29147) * Happy! * opps * one more * Automatic changelog update * shorten short raffle (space-wizards#28685) * Automatic changelog update * Fix some lathe recipe textures showing up blank (space-wizards#28683) * Update lathes to use entity prototype * ScrollContainer my hero * gets rid of excess newlines --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Grammar fix to medibot! (space-wizards#29197) fixed * Restore default panic bunker and tweak baby jail (space-wizards#29198) restore default panic bunker * Fixed cartridges installing more than once (space-wizards#29187) * fixed cartridges installing more than once * replaced prototypes with CartridgeComponent * relocated checks from InstallProgram to InstallCartridge * Automatic changelog update * Musician's skirt (space-wizards#29203) * Sprites&Meta * Changing prototypes * Adding to Theater vend * Sprite_Change * Sprite_Change * Prototype_Changes Is this exactly how it should be?... * FUCKING FIX * weh --------- Co-authored-by: Арт <123451459+JustArt1m@users.noreply.github.com> * Automatic changelog update * hos cap resprite (space-wizards#29208) * hos cap resprite * 1. 2. 3 4 Oh * Automatic changelog update * Rejig device link sink & source startup & shutdown (space-wizards#29035) * Fix DeviceLinkSinkComponent not updating sources on shutdown * Log error * Misc link changes & fixes * Fix core * Add prediction for Tech Disks, cleanup (space-wizards#29061) * Add prediction for Tech Disks, cleanup * Remove IsServer check in OnMapInit * Use HashSet for techs, remove LINQ * Code cleanup: radio jammer (space-wizards#29052) * Code cleanup for radio jammer * More Entity<T> for the people, and fix an accidental variable reuse * Partial buckling refactor (space-wizards#29031) * partial buckling refactor * git mv test * change test namespace * git mv test * Update test namespace * Add pulling test * Network BuckleTime * Add two more tests * smelly * Fix documentation typo (space-wizards#29209) Fix everything. * Emergency toolbox fill rework (space-wizards#29202) * emergency toolbox fill rework * Fuck * Add wet floor sign & warning cone to autolathe (space-wizards#29205) * Add wet floor sign & warning cone to autolathe * removing * Automatic changelog update * Tools batch files (space-wizards#29179) * Tools batch files * fine * Fix terrible portable scrubber unlit layers (space-wizards#29232) Jesus fucking christ man * Prevent fly-by fixture from powering containment field generator (space-wizards#29225) * Prevent fly-by fixture from powering containment field generator * Update according to review * Automatic changelog update * Hide moth antenna and lizard frills with hardsuit helmets, fix lizard snouts not being hidden (space-wizards#29214) * inital * Update ClothingSystem.cs * Update helmets.yml * Automatic changelog update * Fix and enable TestEmptyLoadout (space-wizards#29228) * Fix and enabled TestEmptyLoadout * Fine, have a real name * Fix brokey code :) * Fix entities getting stuck red (space-wizards#28981) * Automatic changelog update * Update submodule to 226.2.0 (space-wizards#29247) * add a type specifier where one was forgor (space-wizards#29250) * add a type specifier where one was forgor * Fix other way because degub conditions * okay this feels kinda dumb but it does fix it. * Update Content.Client/Effects/ColorFlashEffectSystem.cs --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Make winter coat hood hide certain markings (space-wizards#29238) Update base_clothinghead.yml * Fix ERT becoming sleeper agents and add sleeper agent preferences (space-wizards#27817) * b * Update antags.ftl * m * ok * Update events.yml * antag * a * Create InitialInfectedExemptComponent.cs * Delete InitialInfectedExemptComponent.cs * yes * Delete InitialInfectedExemptComponent.cs * Create AntagImmuneComponent.cs * Automatic changelog update * fixed Syndicate smokes pack being half-filled (space-wizards#28371) * Automatic changelog update * Buff cube boxes (space-wizards#29251) * Automatic changelog update * moves explosive tech to T1 (space-wizards#29227) moves explo tech to T1 * Automatic changelog update * made cup ramen eatable with anything with the fork component (space-wizards#27826) * made cup ramen eatable with anything with the fork component * removed extra png * made cupramen fillable with water, and made hot ramen dry ramen. --------- Co-authored-by: redfire1331 <Redfire1331@users.noreply.github.com> * Automatic changelog update * Survival Box Loadouts, Nitrogen Emergency tanks (space-wizards#29131) * Nitrogen survival boxes * Zero-setup workaround * clown box * cleanup and universal tanks * cleanup * more cleanup * hide loadoutgroups * remaining survival boxes * space ninja * Revert "space ninja" This reverts commit a650f41. * weh * weh * undo appearance change of syndicate survival boxes * indentation fix and missing label * You can now pry multiple tiles at once (space-wizards#29231) * You can now pry multiple tiles at once * More advanced do after duplicate checking. Instead of just saying "lol tile prying can raise duplicates", we now have a system so tile prying can properly distinguish events on 2 different tiles. This is achieved with a virtual function on DoAfterEvent. * Automatic changelog update * Fix prying speed & log (space-wizards#29210) * cleanup prototypes with `PryingComponent` & fix jaws of life prying speed * Minor cleanup for tools and prying systems Remove some obsolete methods. * Fix doafter continues when not held & log * Modifiy delays for floor prying * Fix test fail * Automatic changelog update * golden plunger (space-wizards#29043) * golden plunger * Add wood material (the handle is still wood) * 52 hours --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Rate limit ahelps (space-wizards#29219) * Make chat rate limits a general-purpose system. Intending to use this with ahelps next. * Rate limt ahelps Fixes space-wizards#28762 * Review comments * return empty string for invalid identity (space-wizards#29274) Co-authored-by: deltanedas <@deltanedas:kde.org> * Make Loadout MinLimit not count failed attempts (space-wizards#29264) Loadout MinLimit doesn't count failed attempts * Add logging to SharedStorageSystem prototype indexing failure (space-wizards#29273) * Fix null exceptions in SurveillanceCameraMonitorSystem (space-wizards#29275) * Add IsNullOrEmpty checks before indexing KnownSubnets * actor * Make stasis bed power toggleable (space-wizards#29268) Stasis bed is now power toggleable * Automatic changelog update * Replace BlockSolutionAccessComponent with an attempt event (space-wizards#26988) * BlockSolutionAccessComponent now only blocks one specified solution. * Significant overhaul Separated spilling when worn functionality into its own component/system. Removed BlockSolutionAccessComponent. Added an event for solution access. * fix initial infected icons and add a briefing to the character menu (space-wizards#29259) * Automatic changelog update * feat: update cyborg parts naming for them to be ordered consistently,… (space-wizards#29272) feat: update cyborg parts naming for them to be ordered consistently, closes space-wizards#29270 --------- Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com> Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com> Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com> Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com> Co-authored-by: osjarw <62134478+osjarw@users.noreply.github.com> Co-authored-by: Vasilis <vasilis@pikachu.systems> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: Rouge2t7 <81053047+Sarahon@users.noreply.github.com> Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com> Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com> Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com> Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com> Co-authored-by: HS <81934438+HolySSSS@users.noreply.github.com> Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com> Co-authored-by: plykiya <plykiya@protonmail.com> Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com> Co-authored-by: Truoizys <153248924+Truoizys@users.noreply.github.com> Co-authored-by: Арт <123451459+JustArt1m@users.noreply.github.com> Co-authored-by: TsjipTsjip <19798667+TsjipTsjip@users.noreply.github.com> Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> Co-authored-by: Alice "Arimah" Heurlin <30327355+arimah@users.noreply.github.com> Co-authored-by: neutrino <67447925+neutrino-laser@users.noreply.github.com> Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com> Co-authored-by: Redfire1331 <125223432+Redfire1331@users.noreply.github.com> Co-authored-by: redfire1331 <Redfire1331@users.noreply.github.com> Co-authored-by: MilenVolf <63782763+MilenVolf@users.noreply.github.com> Co-authored-by: Ghagliiarghii <68826635+Ghagliiarghii@users.noreply.github.com> Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: Alex Pavlenko <diraven@users.noreply.github.com>

Disable footstep sounds for ghosts

845c8f8

Adds a check before playing footstep sounds to check if the mover is a ghost. Doesn't play footstep sounds if they are a ghost.

Moneyl requested review from PJB3005 and ZoldorfTheWizard as code owners September 17, 2019 01:32

PJB3005 requested changes Sep 18, 2019

View reviewed changes

PJB3005 added the T: Bugfix Type: Bugs and/or bugfixes label Sep 18, 2019

Add FootstepSoundComponent

4ea396e

Adds FootstepSoundComponent. If a mob has this component, it will make footstep sounds. Otherwise they will not. As of this commit humans have this component and ghosts do not.

PJB3005 approved these changes Sep 20, 2019

View reviewed changes

PJB3005 merged commit 0090af6 into space-wizards:master Sep 20, 2019

Moneyl deleted the NoGhostFootstepSounds branch November 23, 2019 23:40

rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Oct 1, 2022

Merge pull request space-wizards#343 from Pspritechologist/Atlas_Update

2ee1fd5

Atlas update

rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Oct 2, 2023

Merge pull request space-wizards#343

03dbf87

* decal touchup

deltanedas pushed a commit to deltanedas/space-station-14 that referenced this pull request Sep 21, 2024

Merge pull request space-wizards#343 from greystation14/Localize-Stea…

3422950

…l-Groups Localize X-01 Steal Goal

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable footstep sounds for ghosts #343

Disable footstep sounds for ghosts #343

Moneyl commented Sep 17, 2019

PJB3005 Sep 18, 2019

Moneyl Sep 20, 2019

PJB3005 Sep 20, 2019

Disable footstep sounds for ghosts #343

Disable footstep sounds for ghosts #343

Conversation

Moneyl commented Sep 17, 2019

PJB3005 Sep 18, 2019

Choose a reason for hiding this comment

Moneyl Sep 20, 2019

Choose a reason for hiding this comment

PJB3005 Sep 20, 2019

Choose a reason for hiding this comment