Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtestable Brigmedic Rework #34513

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

minus1over12
Copy link
Contributor

@minus1over12 minus1over12 commented Jan 19, 2025

About the PR

Partial implementation of space-wizards/docs#370 to allow for admins to playtest the role. Merging this should have minimal effect outside of admin controlled rounds, as none of the maps have Brigmedic enabled and Brigmedic is not selectable in the character editor. Interested admins can use the command stations:get jobs:job Brigmedic jobs:set 1 to add Brigmedic as a late join role for eligible players.

Why / Balance

Allows getting concrete answers to how some of the changes pan out, without fully releasing Brigmedic into the wild. See the proposal for more details.

Technical details

The brigmedic removal was partially reverted again. The role was updated to the current loadout system. Some of the changes proposed in the proposal were applied to relevant YAML. The brigmedic gear was changed to medical contraband.

Media

Brigmedic on a station

Requirements

Breaking changes

Changelog

🆑 WarPigeon

  • tweak: Brigmedic's department was changed from Security to Medical.
  • tweak: Brigmedic gear's combat capabilities were nerfed.
  • tweak: Brigmedic now requires Psychologist and Warden playtime.

ADMIN:

  • add: An incomplete Brigmedic rework is available for playtesting as a late join role. Please read Brigmedic Rework docs#370 before attempting to use it, be ready to guide the lucky player on what their job is, and provide feedback on that PR after the round.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Jan 19, 2025
@metalgearsloth
Copy link
Contributor

I don't really understand why this is a discrete role and not just a loadout as it goes against the design of all the other secondary roles:

  • chem, diff access
  • AT, diff access

@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Jan 19, 2025
@Aisu9
Copy link

Aisu9 commented Jan 19, 2025

considering this is mainly a medical job, it shouldn't have external access because CMO doesn't have external access

Thank you @Aisu9 for pointing out I missed this
@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Medical Area: Medical department, including Chemistry A: Security Area: Security department, including Detectives, HoS labels Jan 19, 2025
@Entvari
Copy link

Entvari commented Jan 19, 2025

I don't understand the need for psychologist playtime. Feels like possibly the least relevant medical role unless you're providing evaluations to prisoners, in which case you don't really need alot of experience.
I feel chemist and/or paramedic playtime would be much better picks as they provide skills you'd actively use as a brigmed.

@Nimfar11
Copy link
Contributor

A brig medic is supposed to be more of a medic than a brig member. Access to medics and to the brig, no weapons by roundstart. Keep him away from the officers' activities, and closer to the medics.

@TheDoctor1977
Copy link

I feel chemist and/or paramedic playtime would be much better picks as they provide skills you'd actively use as a brigmed.

Seconding this, Paramedic playtime seems much more appropriate, especially considering the Paramedic often occupies a similar "combat medic" role during nukies.

@Aisu9
Copy link

Aisu9 commented Jan 20, 2025

paramedic would be better suited as a requirement, brigmedics have nothing to do inside chemistry as it is not what they signed for.

@keronshb
Copy link
Contributor

I think brigmedic as a loadout accidentally slipped in and wasn't intended.
If they want a medic they should have to go to medical and ask for a docs assistance and not have their very own role for this.

@keronshb keronshb added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Jan 20, 2025
@minus1over12
Copy link
Contributor Author

The psychologist requirement is because one of the things I mentioned in the design proposal is a desire for the Brigmedic to take care of the psychological needs of the incarcerated in addition to physical treatment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Medical Area: Medical department, including Chemistry A: Security Area: Security department, including Detectives, HoS Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants