Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removal of std references for initial no_std support #172

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

JayWhite2357
Copy link
Contributor

Rationale for this change

In order to be able to update commitments from within a no_std environment (like WASM), we need to allow a portion of the sxt-proof-of-sql crate to be no_std compatible. This PR does the first step of this support.

What changes are included in this PR?

  • The first commit refactors some code to no longer reference std directly, but rely on use statements instead.
  • The second commit adds/modifies use statements in order to remove std from the relevant portion of the crate.

Are these changes tested?

Yes, by existing tests.

@JayWhite2357 JayWhite2357 force-pushed the refactor/no-std-commitment-setup branch 2 times, most recently from 1e92c90 to bb99daf Compare September 21, 2024 01:25
Copy link
Contributor

@tlovell-sxt tlovell-sxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iajoiner iajoiner force-pushed the refactor/no-std-commitment-setup branch from bb99daf to 25014de Compare September 22, 2024 07:16
@iajoiner iajoiner merged commit 067d7c9 into main Sep 22, 2024
10 checks passed
@iajoiner iajoiner deleted the refactor/no-std-commitment-setup branch September 22, 2024 13:29
Copy link

🎉 This PR is included in version 0.22.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants