feat: add initial no_std support (for commitments)
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See dtolnay/thiserror#304 for more information. We likely want to wait for the PR to merge to complete this version. |
JayWhite2357
force-pushed
the
feat/no-std-commitment
branch
from
d902b22 to
41a0a01
Compare
|
Should this be closed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to be able to update commitments from within a no_std environment (like Substrate's WASM), we need to allow a portion of the
proof-of-sqlcrate to be no_std compatible. This PR is a follow-up of #172 that completes the work.What changes are included in this PR?
proof-of-sqlcrate.#[cfg(feature = "std")]are added to large portions of the code. These can eventually be removed. At the moment, only the relevant portions are madeno_std.thiserroris bumped to a non-release branch that supportscore::error::Error.Are these changes tested?
Yes, by existing tests.