Trim the spaces before persisting to a state file #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MikeMcMahon, looks good to me! Before I merge could I just ask that you bump the minor version (so it would become v0.2.0) in the version file and update the ChangeLog to reflect your changes? |
|
I've updated the README as well, i meant to unwind that commit and can back it out. We have actually patched all of the afflicted clusters :) |
|
Thanks, good to know all of the clusters have the fix. If you could update CHANGELOG.md with you v0.2.0 changes then I'll merge this PR. |
|
consider it done, and let me know if anything else needs touching up ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.