Trim the spaces on reading from wavefront #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathmclean @louism517 please review. |
|
bump @nathmclean @louism517 |
|
bump @nathmclean @louism517 |
|
@ashwin1dd Sorry for the delay. There're some failing tests at the moment (nothing to do with your changes) I just want to get them fixed so I can run the test suite against all PRs. Then I'll get this merged in ASAP. Should be done today/tomorrow |
|
sounds good, thanks @nathmclean! |
|
thanks! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WF seems to be adding a lot of newline chars, compared to tfstate which leads to a lot of noise due to no-op changes: i.e.
"(some condition) > 100\n" => "(some condition) > 100"Similar vein as #21
Open to any feedback!