Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about release Apple silicon binary version ? #8

Open
Pillar1989 opened this issue Nov 14, 2021 · 5 comments
Open

How about release Apple silicon binary version ? #8

Pillar1989 opened this issue Nov 14, 2021 · 5 comments

Comments

@Pillar1989
Copy link

How about release Apple silicon binary version ?

@spacemeowx2
Copy link
Owner

actions/runner-images#2187

Seems need to wait Github actions to support this platform

@GPSBabelDeveloper
Copy link

GPSBabelDeveloper commented Feb 2, 2022

Does the Intel version not run under Rosetta?
I just pulled the source onto an M1 and typed 'cargo build' (there probably should be a Makefile or a paragraph in doc...) If that's a correct way to build, it does indeed fail, but not "obviously" in an M1-specific way.

@Pillar1989 , is this the error that cause you to file the bugreport?

Compiling bitvec v0.22.3
Compiling clap v2.33.3
error[E0433]: failed to resolve: could not find addr_of in ptr
--> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitvec-0.22.3/src/ptr/single.rs:141:17
|
141 | unsafe { ptr::addr_of!(self.addr).read_unaligned() }
| ^^^^^^^ could not find addr_of in ptr

Compiling serial-unix v0.4.0
error[E0658]: const generics are unstable
--> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitvec-0.22.3/src/array/traits.rs:204:22
|
204 | impl<'a, O, T, const N: usize> TryFrom<&'a BitSlice<O, T>>
| ^
|
= note: see issue #74878 rust-lang/rust#74878 for more information

error[E0658]: const generics are unstable
--> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitvec-0.22.3/src/array/traits.rs:244:22
|
244 | impl<'a, O, T, const N: usize> TryFrom<&'a BitSlice<O, T>>
| ^
|
= note: see issue #74878 rust-lang/rust#74878 for more information

error[E0658]: const generics are unstable
--> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitvec-0.22.3/src/array/traits.rs:285:22
|
285 | impl<'a, O, T, const N: usize> TryFrom<&'a mut BitSlice<O, T>>
| ^
|
= note: see issue #74878 rust-lang/rust#74878 for more information

error[E0658]: const generics are unstable
--> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitvec-0.22.3/src/view.rs:135:15
|
135 | impl<T, const N: usize> BitView for [T; N]
| ^
|
= note: see issue #74878 rust-lang/rust#74878 for more information

error[E0658]: const generics are unstable
--> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitvec-0.22.3/src/view.rs:171:15
|
171 | impl<T, const N: usize> BitViewSized for [T; N]
An undeclared crate, module, or type was used.

Erroneous code example:

let map = HashMap::new();
// error: failed to resolve: use of undeclared type `HashMap`

Please verify you didn't misspell the type/module's name or that you didn't
forget to import it:

use std::collections::HashMap; // HashMap has been imported.
let map: HashMap<u32, u32> = HashMap::new(); // So it can be used!

If you've expected to use a crate name:

use ferris_wheel::BigO;
// error: failed to resolve: use of undeclared crate or module `ferris_wheel`

Make sure the crate has been added as a dependency in Cargo.toml.

To use a module from your current crate, add the crate:: prefix to the path.
...skipping...
| ^
|
= note: see issue #74878 rust-lang/rust#74878 for more information

Compiling serial v0.4.0
Compiling digest v0.9.0
Compiling block-buffer v0.9.0
Compiling parse_int v0.5.0
Compiling regex v1.5.4
Compiling sha2 v0.9.5
Compiling console v0.14.1
Compiling env_logger v0.8.3
Compiling indicatif v0.16.0
error: aborting due to 6 previous errors

Some errors have detailed explanations: E0433, E0658.
For more information about an error, try rustc --explain E0433.
error: could not compile bitvec

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

@spacemeowx2 , I don't know Rust but I can type things and report results. I could probably help make a build available, but it's probably best to focus on making it trivial to build for everyone.

I have PineCone/PineNut, DoIT, and a few other misc Bouffalo boards where I can do pass/fail testing if it's helpful. The upload barrier has been the reasons those boards have been largely idle.

@spacemeowx2
Copy link
Owner

spacemeowx2 commented Feb 3, 2022

@GPSBabelDeveloper Make sure your rust version is latest stable(install using rustup). I just compiled on M1 without error.

https://doc.rust-lang.org/stable/std/ptr/macro.addr_of.html

See top right of the page, you can see addr_of is added in 1.51.0

@GPSBabelDeveloper
Copy link

GPSBabelDeveloper commented Feb 6, 2022 via email

@robertlipe
Copy link
Contributor

With #10 integration, multiple users on M1 (including me), and OP's silence of many months, this can surely be closed. Thank you, @spacemeowx2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants