Updated to deku 0.10 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required passing a lifetime param to DekuContainerRead, but it didn't spread as we only need to check the bit offset.
|
This should fix the errors I get when compiling from source which stem from bitvec. |
|
Thank you! |
|
The funty dependency also needs to be updated to 1.2 in order for this to solve the bitvec error. There's an issue on upstream bitvec that would solve this by changing their dependency version, but in the meantime blflash should probably just update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required passing a lifetime param to DekuContainerRead, but it didn't spread
as we only need to check the bit offset.