Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused gwcs_types #443

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

braingram
Copy link
Collaborator

The gwcs_types submodule is unused and uses the deprecated extension api in asdf. This will create warnings in asdf 2.15 and fail to work with asdf 3.0 as is described in #441

This PR removes gwcs_types.

fixes #441

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (2e39161) 86.95% compared to head (4c7937e) 86.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   86.95%   86.87%   -0.09%     
==========================================
  Files          25       24       -1     
  Lines        3895     3871      -24     
==========================================
- Hits         3387     3363      -24     
  Misses        508      508              
Flag Coverage Δ
unit 86.87% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@braingram
Copy link
Collaborator Author

braingram commented Mar 1, 2023

The jwst CI job failure appears in a file in scripts:
https://github.com/spacetelescope/gwcs/actions/runs/4304658164/jobs/7505997639#step:12:280
This directory is ignored in the jwst tests:
https://github.com/spacetelescope/jwst/blob/4285c4efb95bc368f36456e9e106e6aba6abd597/setup.cfg#L152
Likely the CI job here in gwcs should be updated to exclude testing these files. EDIT: see #444

@braingram braingram mentioned this pull request Mar 1, 2023
@braingram braingram force-pushed the remove_gwcs_types branch from 1c06a5e to 4c7937e Compare March 1, 2023 17:25
@braingram braingram requested a review from mcara March 2, 2023 16:11
@mcara mcara requested a review from nden March 2, 2023 18:58
Copy link
Member

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Test failure (pointing_summary) is unrelated.

@mcara mcara merged commit 7b32eb5 into spacetelescope:master Mar 2, 2023
@braingram braingram deleted the remove_gwcs_types branch March 2, 2023 19:18
@nden nden added this to the 0.19 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gwcs_types.py
3 participants