Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jwst ci job #444

Merged
merged 1 commit into from
Mar 1, 2023
Merged

fix jwst ci job #444

merged 1 commit into from
Mar 1, 2023

Conversation

braingram
Copy link
Collaborator

jwst ignores the scripts directory for pytest
https://github.com/spacetelescope/jwst/blob/4285c4efb95bc368f36456e9e106e6aba6abd597/setup.cfg#L152
this PR replicates that ignore to address CI failures seen for:
#443

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b1a57cb) 86.95% compared to head (33d06e2) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          25       25           
  Lines        3895     3895           
=======================================
  Hits         3387     3387           
  Misses        508      508           
Flag Coverage Δ
unit 86.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator

looks good! One thing though, should the change to gwcs/gwcs_types.py be in this PR?

@braingram
Copy link
Collaborator Author

looks good! One thing though, should the change to gwcs/gwcs_types.py be in this PR?

No :-O sorry for that. Thanks for catching that.

@zacharyburnett zacharyburnett merged commit 2e39161 into spacetelescope:master Mar 1, 2023
@braingram braingram deleted the ci/jwst branch March 1, 2023 17:22
@nden nden added this to the 0.19 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants