fix support for ipywidgets 8 and remove max pin (#1592)

* avoid accessing app.widgets/_active_widgets entirely * Revert "pin max version of ipywidgets" This reverts commit 5ac6fe4.
spacetelescope · Aug 22, 2022 · 3bb4523 · 3bb4523
1 parent 2b26bb1
commit 3bb4523
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -81,6 +81,8 @@ Bug Fixes
  and visibility states are now always adopted from the existing entry that would be overwritten.
  [#1538]
 
+- Fix support for ipywidgets 8 (while maintaining support for ipywidgets 7). [#1592]
+
 Cubeviz
 ^^^^^^^
 

diff --git a/jdaviz/app.py b/jdaviz/app.py
@@ -1179,7 +1179,7 @@ def resize(stack_items):
  # resize tray items
  for tray_item in self.state.tray_items:
  # access the actual plugin object (there is no store for plugins)
- tray_obj = self.widgets.get(tray_item['widget'].split('IPY_MODEL_')[1])
+ tray_obj = widget_serialization['from_json'](tray_item['widget'], None)
  for bqplot_fig in tray_obj.bqplot_figs_resize:
  bqplot_fig.layout.height = '99.9%'
  bqplot_fig.layout.height = '100%'

diff --git a/setup.cfg b/setup.cfg
@@ -31,7 +31,6 @@ install_requires =
  ipyvuetify>=1.7.0
  ipysplitpanes>=0.1.0
  ipygoldenlayout>=0.3.0
- ipywidgets<8.0
  voila>=0.3.5
  pyyaml>=5.4.1
  specutils>=1.7.0