Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for ipywidgets 8 and remove max pin #1592

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 22, 2022

Description

This pull request attempts to support ipywidgets 8 change in .widgets becoming a private ._active_widgets while still supporting the old syntax.

xref jupyter-widgets/ipywidgets#3122

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 2.9 milestone Aug 22, 2022
@kecnry kecnry mentioned this pull request Aug 22, 2022
9 tasks
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1592 (6899c64) into main (25c351b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6899c64 differs from pull request most recent head 7f54448. Consider uploading reports for the commit 7f54448 to get more accurate results

@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          94       94           
  Lines        9290     9290           
=======================================
  Hits         7966     7966           
  Misses       1324     1324           
Impacted Files Coverage Δ
jdaviz/app.py 91.79% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jdaviz/app.py Show resolved Hide resolved
@kecnry kecnry marked this pull request as ready for review August 22, 2022 14:58
@pllim pllim requested a review from havok2063 August 22, 2022 14:59
@kecnry
Copy link
Member Author

kecnry commented Aug 22, 2022

Let's squash and merge when this is approved (to get rid of the failed attempt from the commit history, but its nice to keep here in the PR so I'll avoid squashing in this branch).

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving by proxy. Maybe @havok2063 want to have a look too, just in case?

"... that’s a nice solution! It will not impact performance." -- Mario B. ⭐⭐⭐⭐⭐

@kecnry kecnry changed the title support ipywidgets 7 and 8 when accessing app.widgets/_active_widgets fix support for ipywidgets 8 and remove max pin Aug 22, 2022
Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kecnry kecnry merged commit 3bb4523 into spacetelescope:main Aug 22, 2022
@kecnry kecnry deleted the fix-app-widgets branch August 22, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants