Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: pin max version of ipywidgets #1591

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 22, 2022

Description

This pull request pins the max version of ipywidgets until we can fix support with ipywidgets 8.0

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 2.9 milestone Aug 22, 2022
@kecnry kecnry added no-changelog-entry-needed changelog bot directive 🔥 Critical labels Aug 22, 2022
@kecnry kecnry marked this pull request as ready for review August 22, 2022 13:52
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1591 (5ac6fe4) into main (2c8d971) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1591   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          94       94           
  Lines        9290     9290           
=======================================
  Hits         7966     7966           
  Misses       1324     1324           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kecnry kecnry added the trivial Only needs one approval instead of two label Aug 22, 2022
@pllim
Copy link
Contributor

pllim commented Aug 22, 2022

Since you found the actual compat problem, should we just turn this PR into compat fix?

jupyter-widgets/ipywidgets#3122

@kecnry
Copy link
Member Author

kecnry commented Aug 22, 2022

Attempt to support ipywidgets 7 and 8 by trying to access ._active_widgets and falling back on .widgets: #1592

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since compatibility fix is in another PR, let's get this in now. Thanks!

@pllim pllim merged commit 25c351b into spacetelescope:main Aug 22, 2022
@kecnry kecnry deleted the max-ipywidgets branch August 24, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Critical no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants