move build configuration to pyproject.toml

[zacharyburnett]

setuptools now supports the [project] table, which is defined by PEP621.

Additionally, setuptools now supports its own entry in pyproject.toml called [tool.setuptools] (pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:

Support for declaring configurations not standardized by PEP 621 (i.e. the [tool.setuptools] table), is still in beta stage and might change in future releases.

Reading toml is supported natively in Python 3.11 with tomllib

Given this, we can attempt to consolidate the build configuration into a single pyproject.toml file that can possibly be read by other build systems in the future.

[mfixstsci]

Thanks @zacharyburnett! This is really helpful, sorry it took me some time to get around to it!

[zacharyburnett]

Thanks @zacharyburnett! This is really helpful, sorry it took me some time to get around to it!

No problem! The CI seems to be failing because it never calls pip install ., but that should be easy to fix

[mfixstsci]

@zacharyburnett I noticed and am updating some of the docs/removing deprecated test runs etc. I am hoping to have it in better shape this afternoon!

[pllim]

Are you sure this PR is complete?

E ModuleNotFoundError: No module named 'requests'

Should not merge PR with red CI, if possible.

[pllim]

Are you sure you need oldest-supported-numpy . Do you have C-extension that uses numpy ABI?

[mfixstsci]

@zacharyburnett I am assuming this a hold over from the setup.py file. I can double check and open a new PR with a fix.

[mfixstsci]

Looks like we versioned numpy in the setup.py file. Any reason for using the "oldest-supported-numpy" version?

[pllim]

This section is for build, not install. Do you need numpy during compile time?

[mfixstsci]

Ah, right sorry. I don't believe we do!

[pllim]

Then you should remove it. Will make your lives easier when Python 3.12 and NumPy 2.0 are released.

[mfixstsci]

Are you sure this PR is complete?

E ModuleNotFoundError: No module named 'requests'

Should not merge PR with red CI, if possible.

I agree, but sadly the tests have been failing for some time now. There are some issues that are instrument specific that cause them which are out of @Witchblade101 and I's expertise. In this case I was wrong and should have double checked.

[mfixstsci]

Are you sure this PR is complete?
E ModuleNotFoundError: No module named 'requests'
Should not merge PR with red CI, if possible.

I agree, but sadly the tests have been failing for some time now. There are some issues that are instrument specific that cause them which are out of @Witchblade101 and I's expertise. In this case I was wrong and should have double checked.

@pllim maybe it was an issue with python 3.7 because @zacharyburnett just added another PR #319 and the test are all passing now 🎉