-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move stnode into a sub-package #213
Move stnode into a sub-package #213
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 94.25% 94.48% +0.22%
==========================================
Files 18 25 +7
Lines 1742 1778 +36
==========================================
+ Hits 1642 1680 +38
+ Misses 100 98 -2
☔ View full report in Codecov by Sentry. |
d600757
to
b9bcea6
Compare
86d2414
to
5620e98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a minor docstring error, it looks good. I had to refresh my brain by looking at the original code (even though I wrote much of it, but not the dynamic aspects) and that took some time.
---------- | ||
ctx : | ||
An ASDF file context. | ||
tag_uri : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the function signature
2f4c296
to
40a417c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
40a417c
to
fabcc6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR moves
stnode
into a sub-package and then splits module apart into separate modules each handling one part of the functionality ofstnode
. In addition to the split, I have adjusted the names of some of the private functions and added further documentation of stnode. Hopefully, the split of responsibilities combined with the additional inline code documentation will makestnode
easier to maintain.In addition, to the split/document, I also simplified a few parts of the code:
metaclass
based registry of node classes, and replaced it with__init_subclass__
registry. The metaclasses are more than we need for this application.Checklist
CHANGES.rst
under the corresponding subsection