Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ASDF extension into stnode #220

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Jun 22, 2023

This PR refactors the ASDF extension so that it exists entirely within the stnode sub-package because it is really an ASDF extension to handle serialization/deserialization of the stnode objects. This also makes the API for the extension explicitly private, as it should only be used by roman_datamodels to register itself as an ASDF extension.

Checklist

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner June 22, 2023 23:05
@WilliamJamieson WilliamJamieson marked this pull request as draft June 22, 2023 23:05
@WilliamJamieson
Copy link
Contributor Author

This PR is based off the changes in #213, so it will remain a draft until that PR is merged.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: -0.05 ⚠️

Comparison is base (2dd4d7f) 94.48% compared to head (628693f) 94.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   94.48%   94.44%   -0.05%     
==========================================
  Files          25       24       -1     
  Lines        1778     1782       +4     
==========================================
+ Hits         1680     1683       +3     
- Misses         98       99       +1     
Impacted Files Coverage Δ
src/roman_datamodels/stnode/_converters.py 98.33% <92.30%> (-1.67%) ⬇️
src/roman_datamodels/datamodels/_core.py 89.67% <100.00%> (-0.06%) ⬇️
src/roman_datamodels/stnode/_integration.py 100.00% <100.00%> (ø)
src/roman_datamodels/stnode/_registry.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson force-pushed the refactor/asdf_extension branch 4 times, most recently from 2c7143d to 430e333 Compare June 23, 2023 18:00
@WilliamJamieson WilliamJamieson marked this pull request as ready for review June 23, 2023 18:13
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment/question about NODE_EXTENSIONS and docs but looks good to me!

src/roman_datamodels/stnode/_converters.py Show resolved Hide resolved
@WilliamJamieson WilliamJamieson merged commit 9e60328 into spacetelescope:main Jun 24, 2023
@WilliamJamieson WilliamJamieson deleted the refactor/asdf_extension branch June 24, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants