tile_shape should be a tuple if provided. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 71.27% 71.27%
=======================================
Files 18 18
Lines 463 463
=======================================
Hits 330 330
Misses 133 133
Continue to review full report at Codecov.
|
csweaver
approved these changes
May 23, 2018
ttung
pushed a commit
that referenced
this pull request
May 24, 2018
#13 provides the wrong default value. It should be None if it's not present, or a tuple if it's present.
This was referenced May 24, 2018
ttung
added a commit
to spacetx/starfish
that referenced
this pull request
May 24, 2018
ttung
added a commit
that referenced
this pull request
May 30, 2018
#13 provides the wrong default value. It should be None if it's not present, or a tuple if it's present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.