fix tile_shape handling if it's not provided. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13 provides the wrong default value. It should be None if it's not present, or a tuple if it's present.
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 71.27% 71.27%
=======================================
Files 18 18
Lines 463 463
=======================================
Hits 330 330
Misses 133 133
Continue to review full report at Codecov.
|
ambrosejcarr
approved these changes
May 30, 2018
ttung
pushed a commit
to spacetx/starfish
that referenced
this pull request
Jun 7, 2018
1. Fix the initialization of default_tile_shape. If the value is unset, we should just copy the unset value (None) rather than try to construct an empty tuple. 2. If we default_tile_shape is not set, grab the shape from the first tile that has the value set. 3. Bump to slicedimage 0.0.0-dev21 to pick up bugfixes spacetx/slicedimage#14, spacetx/slicedimage#15, and spacetx/slicedimage#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13 provides the wrong default value. It should be None if it's not present, or a tuple if it's present.