Skip to content

Conversation

@chapman39
Copy link
Contributor

This PR makes the llvm pathing consistent between llvm and llvm-amdgpu. This way, specifying llvm-amdgpu in the spack.yaml will look like the following.

    llvm-amdgpu:
      externals:
      - spec: llvm-amdgpu@6.4.2
        prefix: /opt/rocm-6.4.2/llvm
        extra_attributes:
          compilers:
            c: /opt/rocm-6.4.2/llvm/bin/amdclang
            cxx: /opt/rocm-6.4.2/llvm/bin/amdclang++
            fortran: /opt/rocm-6.4.2/llvm/bin/amdflang

@chapman39
Copy link
Contributor Author

@v-dobrev

@alecbcs alecbcs self-assigned this Dec 16, 2025
@alecbcs
Copy link
Member

alecbcs commented Dec 16, 2025

@tgymnich @vchuravy @wsmoses @amd-toolchain-support any objections here?
It would be a breaking change to users' configuration, but it makes a lot of sense to me.

Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @chapman39!

@alecbcs alecbcs merged commit 4fcd8dd into spack:develop Dec 22, 2025
17 checks passed
mkrack pushed a commit to mkrack/spack-packages that referenced this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants