Update hebrew locale #2573
Update hebrew locale #2573
Conversation
|
GitHub won't allow me to merge this because it is still a draft. |
|
Yes, I made a few quick fixes, in the next few days I'll finish it and get it out of draft mode |
|
@zorgiepoo It's ready to merge |
Sparkle/he.lproj/Sparkle.strings
Outdated
| "Ready to Install" = "מוכן להתקנה"; | ||
|
|
||
| /* No comment provided by engineer. */ | ||
| "Should %1$@ automatically check for updates? You can always check for updates manually from the %1$@ menu." = "האם %1$@ צריך לבדוק באופן אוטומטי אם יש עדכונים? אתה תמיד יכול לחפש עדכונים באופן ידני מהתפריט של %1$@."; |
There was a problem hiding this comment.
The first %1$ should be %1$@ I think.
There was a problem hiding this comment.
Also the second one might be wrong too.
There was a problem hiding this comment.
It seems to me that it is wrong only in GitHub/VSCode's display which is LTR, and therefore causes a distorted display of mixed Hebrew (RTL) and English (LTR) text
When I copy the line to a div that is set to RTL, it displays properly: https://jsitor.com/WNpswH34x
There was a problem hiding this comment.
Is this how you expect it to look like? It's best to check how the strings look at runtime in an app. I reset the defaults of the Sparkle Test App with defaults delete org.sparkle-project.SparkleTestApp and launched the app twice to get the permission prompt.
There was a problem hiding this comment.
Yes it looks great
I have now also tested the all flow with Sparkle Test App and the format is valid, there are some minor RTL issues but I will file a separate issue on that
| "Updating %@" = "מעדכן את %@"; | ||
|
|
||
| /* No comment provided by engineer. */ | ||
| "Use Finder to copy %1$@ to the Applications folder, relaunch it from there, and try again." = "השתמש ב-Finder כדי להעתיק את %1$@ לתיקיית היישומים, הפעל אותו מחדש משם ונסה שוב."; |
There was a problem hiding this comment.
Formatter token looks like it may be wrong here too.
There was a problem hiding this comment.
Same as #2573 (comment)
|
The Hebrew localization is not currently enabled in SUUpdatePermissionPrompt.xib. It can be enabled in Xcode's File inspector for that file. |
|
I have activated the SUUpdatePermissionPrompt file now |
|
Thank you. I'll merge after the CI automation is done verifying the changes. (One note: it's easier for me to review/track changes if you don't force push commits on the pull request branch. Also typically people create a separate branch when merging changes so they can keep their 2.x branch in sync. Edit: never mind, I see GitHub provides me of a way of comparing different revisions still. Oh well). |
|
Would you like to wait for me to add RLM tags or should we do it in a new PR? |
|
Let's separate it and wait until this one merges. |
I am a native speaker
Fixes # (issue)
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
(Describe all the cases that were tested)
macOS version tested: 14.5