Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for configurable Webhook Job #135

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Add option for configurable Webhook Job #135

merged 3 commits into from
Nov 9, 2022

Conversation

Kazuto
Copy link
Contributor

@Kazuto Kazuto commented Nov 8, 2022

This pull request adds the option for users to extend and override the CallWebhookJob.

This was suggested by @freekmurze as it's a better option to provide the most flexibility when it comes to custom behaviour of the method shouldRemoveFromQueue().

See here: #133 (comment)

src/WebhookCall.php Outdated Show resolved Hide resolved
src/CallWebhookJob.php Outdated Show resolved Hide resolved
@Kazuto Kazuto requested a review from freekmurze November 9, 2022 07:48
@freekmurze freekmurze merged commit 5e14176 into spatie:main Nov 9, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants