Change to protected properties $response, $errorType and $errorMessage in CallWebhookJob
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #135 the option was added to extend or override the
CallWebhookJobby changing the value of the configuration keywebhook_jobto use an extending class.The idea behind this was to give user the ability to let the job fail on certain criterias like response codes or custom behaviour by overriding the
shouldBeRemovedFromQueue()method.Today I've noticed that it slipped my mind that the response, error type and error message are not available to the extending class because the parent class has the properties set to private.
This PR changes them to protected.