Add disallowedMethodCalls.allowCount to allow method calls N times

[ruudk]

Close #86

[spaze]

Hey, thanks for the PR. It looks cool and clean, I like it, good job :-)

If you could change just one more detail and maybe add documentation to README?

[ruudk]

Updated the readme. Please suggest changes if you want.

[spaze]

Thanks, good job! I've just merged it and released 1.10.0.

[ruudk]

I made a small error in my thinking while working on this PR.

This works fine:

parameters:
    disallowedMethodCalls:
        -
            method: 'Generated\MyNamedQuery::execute*()'
            message: 'do not reuse GraphQL queries.'
            allowCount: 1

It will only allow one call to Generated\MyNamedQuery::execute*.

But I want to go to a situation where I have 1 rule generic rule

parameters:
    disallowedMethodCalls:
        -
            method: 'Generated\*Query::execute*()'
            message: 'do not reuse GraphQL queries.'
            allowCount: 1

and it should track it's usages by FQCN instead of by rule.

For example, I have 2 generated classes:

• Generated\MyNamedQuery
• Generated\MyOtherQuery

MyNamedQuery::execute() should be allowed to called once, and MyOtherQuery::execute() should be allowed to call once.

With the current setup, it tracks its usage on the rule and therefore blocks the second call to a separate class.

[ruudk]

To solve that, I would suggest to scope the allowCount by FQCN.

Do you think that makes sense? So wildcard on method does count, but wildcard on class name does not count.

Since the feature is not working (see #88) I don't think it's a breaking change.

[spaze]

Hey, yeah, usually making things work with other things is the hardest part :-)

To solve that, I would suggest to scope the allowCount by FQCN.

I think this is probably the only option we're left with. It would be cool if this can be checked run-time so that method: 'Generated\*Query::execute*()' + allowCount: 1 won't work and will give a warning to users that it won't work so they don't expect it would work. Do you think it would be possible (and easy-ish) to add the check?

[spaze]

FYI, I have moved the new FQCN-related issue to #89