Add missing int() to disallowedMethodCalls type structure
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to add this in spaze#87 Fixes: ``` Invalid configuration: The option 'parameters › disallowedMethodCalls › 2 › allowCount' expects to be string|list|array, 1 given. ```
|
Thanks and nevermind :-) Stuff like this happens but luckily I'm a fan of "release often" so that's not a problem. And yeah, it would be cool to have this tested but here we are :-) |
spaze
approved these changes
Oct 26, 2021
|
I have merged this now but will wait with a release when a fix for #89 is ready (no pressure 😇) Thanks! |
ruudk
added a commit
to ruudk/phpstan-disallowed-calls
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add this in #87
Fixes:
Too bad the tests don't pick this up :(