Initial FPGA Support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
May 20, 2021
Comment on lines
+121
to
+140
| queue = deque([old_edge_in_shape.src]) | ||
| while len(queue) > 0: | ||
| current_node = queue.popleft() | ||
|
|
||
| edges = state.in_edges(current_node) | ||
| state.remove_node(current_node) | ||
| for e in edges: | ||
| next_node = e.src | ||
| if len(state.out_edges(next_node)) == 0: | ||
| queue.append(next_node) | ||
|
|
||
| # get the edges between the the access_node and the nsdfg_node | ||
| old_edges = [ | ||
| e for e in state.out_edges(access_node) if e.dst == nsdfg_node | ||
| ] | ||
|
|
||
| for edge in old_edges: | ||
| state.add_edge(old_edge_in.src, old_edge_in.src_conn, edge.dst, | ||
| edge.dst_conn, old_edge_in.data) | ||
| state.remove_edge(edge) |
There was a problem hiding this comment.
looks a bit excessive here. There are only ever two edges and that's it.
| @@ -0,0 +1,89 @@ | |||
| """ | |||
There was a problem hiding this comment.
what do you mean by the name "plot" in the filename
There was a problem hiding this comment.
plot_ is the default prefix used by sphinx gallery. We can change it if we want, suggestions welcome.
There was a problem hiding this comment.
ok, what do you think about demo_?
|
@TizianoDeMatteis Seems like the main reason for the bad coverage is because reshape elimination is not tested |
tbennun
approved these changes
Jun 9, 2021
This reverts commit 8acd5da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several ONNX Node expansions specifically tailored for FPGA, in particular IntelFPGA.