Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(respec2html): correctly import marked #3864

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

sidvishnoi
Copy link
Member

Caught in w3c/hr-time#130
Will release ASAP.

@sidvishnoi sidvishnoi requested a review from saschanaz November 5, 2021 16:43
@saschanaz
Copy link
Collaborator

Is this still a problem? I don't see the issue on ReSpec 27.0.5, so maybe fixed in their side?

Copy link
Collaborator

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, markedjs/marked#2227 did remove the default export, so approving.

@sidvishnoi
Copy link
Member Author

https://github.com/markedjs/marked/releases says use const { marked }

@sidvishnoi
Copy link
Member Author

Weird it didn't trigger the error in your fork though.

@sidvishnoi sidvishnoi merged commit 22c7f0b into develop Nov 5, 2021
@sidvishnoi sidvishnoi deleted the fix-marked-usage branch November 5, 2021 16:51
@saschanaz
Copy link
Collaborator

Mystery 🤔

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Nov 5, 2021

Released v27.0.6. Mystery solved 😆

@saschanaz
Copy link
Collaborator

Buried rather than solved, but yeah 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants