-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose everywhere #130
Expose everywhere #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yoavweiss marked as non substantive for IPR from ash-nazg. |
I'd want to understand the implementation commitments before landing though... |
Ms2ger marked as substantive for IPR from ash-nazg. |
Note, I don't think WebIDL2.js supports this yet? cc @saschanaz |
The corresponding spec PR is not landed: whatwg/webidl#526 I can prepare a draft PR early, though. |
The next release of ReSpec will include support for this (via WebIDL2.js)... should be landing in the next 24 hours. |
Somehow spec-prod still gets the previous version of webidl2.js and I wonder it implicitly uses a cache for |
spec-prod doesn't cache dependencies (not webidl2.js at least). Can you share where you found it being cached? Current build error seems to be a regression in ReSpec (marked is not a function). Will send a fix and release soon. |
Tried on my fork: https://github.com/saschanaz/hr-time/runs/4119110069?check_suite_focus=true I don't see Edit: BTW, probably useful if it shows which version of the library is installed. |
webidl2 error occurred as an older version got installed in a previous step with
Good point, will add. spec-prod does show for respec/bikeshed, but not for other libraries. Update: Fixed in spec-prod v2 ≡ v2.6.4. |
Now yarn argues that it gets webidl2@24.2.0 but still fails to parse the IDL. Not sure what's happening, since ReSpec itself can now parse it properly with that version. |
@saschanaz Should be ok now with v2.6.5 |
Thanks! Things are definitely not simple 😭 |
Since it now runs well in my fork, probably someone with proper access should rerun the job and then everything should be okay. |
Re-running… |
This should be ready to merge now; I'll submit tests to WPT once the IDL changes have propagated from webref. |
Hey @yoavweiss, is there anything I need to do on my side to move this along? |
Merging as it was approved! Thanks for the poke @Ms2ger! |
This reverts commit e7285a2.
Ref: tc39/proposal-shadowrealm#331
Implementation commitment - primarily for "change" and other normative changes: Positive initial signals from Google, Apple, Mozilla on the general direction.
Tasks:
Preview | Diff