Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose everywhere #130

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Expose everywhere #130

merged 1 commit into from
Jan 28, 2022

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 20, 2021

Ref: tc39/proposal-shadowrealm#331

Implementation commitment - primarily for "change" and other normative changes: Positive initial signals from Google, Apple, Mozilla on the general direction.

Tasks:


Preview | Diff

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w3cbot
Copy link

w3cbot commented Oct 20, 2021

yoavweiss marked as non substantive for IPR from ash-nazg.

@yoavweiss
Copy link
Contributor

I'd want to understand the implementation commitments before landing though...

@w3cbot
Copy link

w3cbot commented Oct 20, 2021

Ms2ger marked as substantive for IPR from ash-nazg.

@marcoscaceres
Copy link
Member

Note, I don't think WebIDL2.js supports this yet? cc @saschanaz

@saschanaz
Copy link
Member

The corresponding spec PR is not landed: whatwg/webidl#526

I can prepare a draft PR early, though.

@marcoscaceres
Copy link
Member

The next release of ReSpec will include support for this (via WebIDL2.js)... should be landing in the next 24 hours.

@saschanaz
Copy link
Member

Somehow spec-prod still gets the previous version of webidl2.js and I wonder it implicitly uses a cache for yarn add? @sidvishnoi

@sidvishnoi
Copy link
Member

@saschanaz

Somehow spec-prod still gets the previous version of webidl2.js and I wonder it implicitly uses a cache for yarn add?

spec-prod doesn't cache dependencies (not webidl2.js at least). Can you share where you found it being cached?

Current build error seems to be a regression in ReSpec (marked is not a function). Will send a fix and release soon.

@saschanaz
Copy link
Member

saschanaz commented Nov 5, 2021

Tried on my fork: https://github.com/saschanaz/hr-time/runs/4119110069?check_suite_focus=true

I don't see marked issue there, but only the validation failure.

Edit: BTW, probably useful if it shows which version of the library is installed.

@sidvishnoi
Copy link
Member

sidvishnoi commented Nov 5, 2021

webidl2 error occurred as an older version got installed in a previous step with yarn add reffy. yarn add webidl2 just decided to use the one available instead of latest as an optimization (yarn's optimization as we didn't ask for specific version). Will use webidl2@latest instead.

BTW, probably useful if it shows which version of the library is installed.

Good point, will add. spec-prod does show for respec/bikeshed, but not for other libraries.


Update: Fixed in spec-prod v2 ≡ v2.6.4.

@saschanaz
Copy link
Member

Now yarn argues that it gets webidl2@24.2.0 but still fails to parse the IDL. Not sure what's happening, since ReSpec itself can now parse it properly with that version.

@sidvishnoi
Copy link
Member

@saschanaz Should be ok now with v2.6.5

@saschanaz
Copy link
Member

Thanks! Things are definitely not simple 😭

@saschanaz
Copy link
Member

saschanaz commented Nov 6, 2021

Since it now runs well in my fork, probably someone with proper access should rerun the job and then everything should be okay.

@marcoscaceres
Copy link
Member

Re-running…

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 18, 2022

This should be ready to merge now; I'll submit tests to WPT once the IDL changes have propagated from webref.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 28, 2022

Hey @yoavweiss, is there anything I need to do on my side to move this along?

@marcoscaceres marcoscaceres merged commit e7285a2 into w3c:gh-pages Jan 28, 2022
@marcoscaceres
Copy link
Member

Merging as it was approved! Thanks for the poke @Ms2ger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants