fix(workspaces): mutate on join workspace #2833
Conversation
| const result = await apollo | ||
| .mutate({ | ||
| mutation: DashboardJoinWorkspaceDocument, | ||
| variables: { | ||
| input: { | ||
| workspaceId: props.workspace.id | ||
| } | ||
| }, | ||
| update(cache) { | ||
| modifyObjectField( |
There was a problem hiding this comment.
You should always use the 2nd param of update - data - to get the actual data from the response and validate that the mutation did in fact go through successfully before you make any cache updates
| getCacheId('User', userId), | ||
| 'workspaces', | ||
| ({ helpers: { createUpdatedValue, ref } }) => { | ||
| return createUpdatedValue(({ update }) => { |
There was a problem hiding this comment.
@cdriesler User.workspaces has variables as well, you usually want to just evict all filtered (e.g. search specified) cache values cause there's no way to accurately tell if the new workspace fits that filter or not. then only modify the lists in non-filtered cache values
There was a problem hiding this comment.
Evict means - wherever that evicted value was referenced, e.g. in some kind of query living in a UI component, the query will understand that its now missing a part of its data and refetch it
|
Ok, updated, but now it's pretty similar to the mutation when creating a workspace. Acceptable for now? |
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References