fix(workspaces): mutate on join workspace #2833
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,11 @@ import { | |
| DashboardJoinWorkspaceDocument, | ||
| type WorkspaceInviteDiscoverableWorkspaceBanner_DiscoverableWorkspaceFragment | ||
| } from '~/lib/common/generated/gql/graphql' | ||
| import { | ||
| getCacheId, | ||
| getFirstErrorMessage, | ||
| modifyObjectField | ||
| } from '~/lib/common/helpers/graphql' | ||
|
|
||
| graphql(` | ||
| fragment WorkspaceInviteDiscoverableWorkspaceBanner_DiscoverableWorkspace on DiscoverableWorkspace { | ||
|
|
@@ -43,6 +47,7 @@ const props = defineProps<{ | |
| }>() | ||
|
|
||
| const { client: apollo } = useApolloClient() | ||
| const { activeUser } = useActiveUser() | ||
| const { triggerNotification } = useGlobalToast() | ||
| const router = useRouter() | ||
|
|
||
|
|
@@ -60,13 +65,34 @@ const processJoin = async (accept: boolean) => { | |
| return | ||
| } | ||
|
|
||
| const userId = activeUser.value?.id | ||
| if (!userId) return | ||
|
|
||
| const result = await apollo | ||
| .mutate({ | ||
| mutation: DashboardJoinWorkspaceDocument, | ||
| variables: { | ||
| input: { | ||
| workspaceId: props.workspace.id | ||
| } | ||
| }, | ||
| update(cache, { data }) { | ||
| const workspaceId = data?.workspaceMutations.join.id | ||
| if (!workspaceId) return | ||
|
|
||
| modifyObjectField( | ||
| cache, | ||
| getCacheId('User', userId), | ||
| 'workspaces', | ||
| ({ variables, helpers: { evict, createUpdatedValue, ref } }) => { | ||
| if (variables.filter?.search?.length) return evict() | ||
|
|
||
| return createUpdatedValue(({ update }) => { | ||
|
There was a problem hiding this comment. @cdriesler User.workspaces has variables as well, you usually want to just evict all filtered (e.g. search specified) cache values cause there's no way to accurately tell if the new workspace fits that filter or not. then only modify the lists in non-filtered cache values There was a problem hiding this comment. Evict means - wherever that evicted value was referenced, e.g. in some kind of query living in a UI component, the query will understand that its now missing a part of its data and refetch it |
||
| update('totalCount', (totalCount) => totalCount + 1) | ||
| update('items', (items) => [...items, ref('Workspace', workspaceId)]) | ||
| }) | ||
| } | ||
| ) | ||
| } | ||
| }) | ||
| .catch(convertThrowIntoFetchResult) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should always use the 2nd param of
update-data- to get the actual data from the response and validate that the mutation did in fact go through successfully before you make any cache updates