Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threading revamp: add ThreadContext and remove Dataflow usage #400

Merged
merged 206 commits into from
Dec 20, 2024

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Nov 21, 2024

Introduces ThreadContext to centrally manage threading across host apps. Most are UI/Worker based but exceptions are noted here:
https://www.notion.so/speckle/Threading-In-Host-Apps-14ab78fc7aa6807ca052c6c0869530d2

jsdbroughton and others added 14 commits November 5, 2024 16:00
* dev:
  moves pointcloud converter to top level (#349)
* dev:
  supporting ICurves as fallback (#339)
  fix(revit): handles plane origin out of bounds and creating group with no elements exceptions (#346)
* dev:
  Fixed autocad async (#370)
  chore: comments
  fix: allows pre-transformation of all ITransformable objects
  adds a setting to send rebars as line or solid (#367)
  Update SDK and dependencies (#366)
  Jrm/parameter extraction (#365)
  dogukan/cnx-753-normals-are-flipped (#364)
  Dogukan/cnx 691 extract appropriate class properties by type (#352)
  Revit async fix for sending (#362)
  feat: adds top level converter for railings
  dogukan/cnx-748-send-grids-from-tekla (#353)
  fix: adds built in category for setting ds cat on receive reliably
  feat: CXPLA-120 Added tekla zip packaging prior to installers (#357)
  add appId (#358)
  adds logic for rendering rebars as lines and arcs (#356)
  Fixed test failing on german culture (#355)
  CNX-501 Temp folder arcgis (#351)
  receive operation fix (#350)
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 7.38007% with 251 lines in your changes missing coverage. Please review.

Project coverage is 9.24%. Comparing base (abc2d9b) to head (eb21a89).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eckle.Connectors.Common/Threading/ThreadContext.cs 0.00% 48 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs 0.00% 35 Missing ⚠️
...e.Connectors.Common/Operations/ReceiveOperation.cs 0.00% 34 Missing ⚠️
...e.Connectors.DUI/Bindings/SendBindingUICommands.cs 0.00% 20 Missing ⚠️
....Connectors.DUI/Bridge/TopLevelExceptionHandler.cs 48.48% 16 Missing and 1 partial ⚠️
...ckle.Connectors.Common/Operations/SendOperation.cs 0.00% 16 Missing ⚠️
...onnectors.Common/Threading/DefaultThreadContext.cs 0.00% 14 Missing ⚠️
....Connectors.DUI/Bindings/IBasicConnectorBinding.cs 0.00% 12 Missing ⚠️
...le.Connectors.Common/Operations/ReceiveProgress.cs 0.00% 12 Missing ⚠️
...onnectors.DUI/Bindings/OperationProgressManager.cs 0.00% 11 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #400      +/-   ##
========================================
- Coverage   9.40%   9.24%   -0.16%     
========================================
  Files        223     227       +4     
  Lines       4222    4260      +38     
  Branches     497     533      +36     
========================================
- Hits         397     394       -3     
- Misses      3809    3850      +41     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock enabled auto-merge (squash) December 20, 2024 14:08
@adamhathcock adamhathcock merged commit f2f11c3 into dev Dec 20, 2024
3 checks passed
@adamhathcock adamhathcock deleted the remove-dataflow branch December 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants