New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

licence: remove GPL as an alternative licence #118

Closed

isaac-io opened this issue Aug 9, 2022 · 0 comments · Fixed by #119

Assignees

Labels

build

Milestone

Contributor

isaac-io commented Aug 9, 2022 •

edited

Loading

We provide the Speedb code under the Apache licence only, so remove the GPL COPYING file.

As this file is also needed due to the vendoring of GNU Parallel in build_tools/gnu_parallel, remove GNU Parallel as well and rely on the system installed binary instead if found (our instructions require users to install GNU Parallel anyway). We should probably consider adding a built-in solution for the Makefile after landing #103 (along the lines of a patched version of gtest-parallel which supports serialising some of the tests and running non-gtest tests).

The text was updated successfully, but these errors were encountered:

isaac-io self-assigned this

isaac-io added the build label

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

97a5188

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

cffc17b

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io linked a pull request

that will close this issue

Remove the GPL as an alternative licence #119

Merged

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

90d1241

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

d942325

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel (#118)

8e1581b

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

335f97a

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

8707d5d

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

0aedb0c

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

9ea06ff

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

3a14200

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

bdd6bc7

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

2e0d809

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

badb049

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io mentioned this issue

build: remove the dependency on GNU Parallel for running unit tests #122

Closed

isaac-io assigned mrambacher

isaac-io mentioned this issue

Update project license to comply with Apache 2.0 #46

Closed

isaac-io pushed a commit that referenced this issue


          build: pick up Makefile cleanup from upstream (#118)

5ddf18a

This picks up the "Clean up variables for temporary directory" commit
(e03d958) from RocksDB for easier upstreaming
and merging in the future.

Summary:
Having all of TMPD, TMPDIR and TEST_TMPDIR as configuration
parameters is confusing. This change simplifies a number of things by
standardizing on TEST_TMPDIR, while still recognizing the old names
also. In detail:
* crash_test.mk also needs to use TEST_TMPDIR for crash test, so put in
shared common.mk (an upgrade of python.mk)
* Always exporting TEST_TMPDIR eliminates the need to propagate TMPD or
export TEST_TMPDIR in selective places.
* Use --tmpdir option to gnu_parallel so that it doesn't need TMPDIR
environment variable
* Remove obsolete parloop and parallel_check Makefile targets
* Remove undefined, unused function ResetTmpDirForDirectIO()

Pull Request resolved: facebook/rocksdb#9961

Test Plan: manual + CI

Reviewed By: riversand963

Differential Revision: D36212178

Pulled By: pdillinger

fbshipit-source-id: b76c1876c4f4d38b37789c2779eaa7c3026824dd

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

d1e8138

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

97b9bfd

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

8ad67d4

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io pushed a commit that referenced this issue


          build: pick Makefile cleanup changes from upstream (#118)

056c35c

This picks the "Clean up variables for temporary directory" commit
(e03d958) from RocksDB for easier
upstreaming and merging in the future.

Summary:
Having all of TMPD, TMPDIR and TEST_TMPDIR as configuration
parameters is confusing. This change simplifies a number of things by
standardizing on TEST_TMPDIR, while still recognizing the old names
also. In detail:
* crash_test.mk also needs to use TEST_TMPDIR for crash test, so put in
shared common.mk (an upgrade of python.mk)
* Always exporting TEST_TMPDIR eliminates the need to propagate TMPD or
export TEST_TMPDIR in selective places.
* Use --tmpdir option to gnu_parallel so that it doesn't need TMPDIR
environment variable
* Remove obsolete parloop and parallel_check Makefile targets
* Remove undefined, unused function ResetTmpDirForDirectIO()

Pull Request resolved: facebook/rocksdb#9961

Test Plan: manual + CI

Reviewed By: riversand963

Differential Revision: D36212178

Pulled By: pdillinger

fbshipit-source-id: b76c1876c4f4d38b37789c2779eaa7c3026824dd

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

9c0a15e

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

b8d3344

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

4d280eb

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

3bb4ba5

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

f68e8b3

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

f6ca371

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

e07ea42

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

632f58d

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

e0d45e3

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

b38d387

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

08bba94

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

1c19b91

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

c7a7be4

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

87cf553

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

91a03f2

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

60d063d

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

505c3e1

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

fa4e46d

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

isaac-io added a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

cd1b7ca

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

isaac-io added a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

17f9460

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

isaac-io added a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

c80eaec

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

Yuval-Ariel pushed a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

0d4bc95

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

Yuval-Ariel pushed a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

004025e

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

Yuval-Ariel pushed a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

609f38a

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

Yuval-Ariel pushed a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

a13fd1f

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

Yuval-Ariel pushed a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

add4101

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

Yuval-Ariel pushed a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

06497e2

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

Yuval-Ariel pushed a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

a832417

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

Yuval-Ariel pushed a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

ca8e583

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

Yuval-Ariel pushed a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

95598cc

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

udi-speedb pushed a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

6bca31c

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

udi-speedb pushed a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

3a729ed

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

udi-speedb pushed a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

a76d454

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

udi-speedb pushed a commit that referenced this issue


          build: clean up the Makefile a bit (#118)

b14c2c2

Remove dependency on perl, which isn't really needed and can be replaced
with POSIX tools. Also do some minor cleanup of the check targets.

udi-speedb pushed a commit that referenced this issue


          build: allow setting the path to GNU Parallel in the Makefile (#118)

1309f78

This allows using more up to date versions from the user's system as well
as possibly patched versions with additional features.

udi-speedb pushed a commit that referenced this issue


          licence: remove the GPL as an alternative licence (#118)

5c379a1

We only license Speedb under the Apache 2.0 licence, so we need to remove
the GPL text from the repository. Since GNU Parallel is currently
vendored in the repo and requires having a copy of the GPL text, remove
it as well and depend on the system installed binary if exists (out build
instructions ask users to install it anyway, and it's installed in CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment