Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove the dependency on GNU Parallel for running unit tests #122

Closed
isaac-io opened this issue Aug 16, 2022 · 0 comments · Fixed by #243
Closed

build: remove the dependency on GNU Parallel for running unit tests #122

isaac-io opened this issue Aug 16, 2022 · 0 comments · Fixed by #243
Assignees
Labels
build Build related Upstreamable can be upstreamed to RocksDB
Milestone

Comments

@isaac-io
Copy link
Contributor

After #118, we now depend on GNU Parallel being installed on the user's system. Also, as mentioned in the linked PR comment, removing the bundled GNU Parallel also removed the fix for CircleCI (which we currently don't use, but is something that we might want to do anyway).

Add a bundled script (possible based on a slimmed down version of gtest-parallel that supports running non-GTest tests (for c_test) as well as outputting progress every 10 minutes for CircleCI. We already depend on Python for various things during the build, so this doesn't add a new dependency.

@isaac-io isaac-io added the build Build related label Aug 16, 2022
@isaac-io isaac-io changed the title build: remove the dependency on GNU Parallel build: remove the dependency on GNU Parallel for running unit tests Aug 16, 2022
@isaac-io isaac-io assigned AmnonHanuhov and unassigned Guyme Sep 13, 2022
@isaac-io isaac-io added this to the v2.2.0 milestone Oct 26, 2022
AmnonHanuhov added a commit that referenced this issue Dec 11, 2022
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
@Guyme Guyme modified the milestones: v2.2.0, V2.3.0 Dec 27, 2022
AmnonHanuhov added a commit that referenced this issue Jan 6, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
AmnonHanuhov added a commit that referenced this issue Jan 9, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
Yuval-Ariel pushed a commit that referenced this issue Jan 17, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
ayulas pushed a commit that referenced this issue Feb 26, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
Yuval-Ariel pushed a commit that referenced this issue May 1, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
udi-speedb pushed a commit that referenced this issue Dec 4, 2023
…122)

Instead, use gtest-parallel as a bundled script for running both
gtest tests and non-gtest tests (such as c_test, for example).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related Upstreamable can be upstreamed to RocksDB
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants