makefile: tab-completion is broken #147
Assignees
Labels
Comments
isaac-io
added
bug
isaac-io
added a commit
that referenced
this issue
Aug 30, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Sep 16, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Sep 23, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Sep 23, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Sep 29, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Sep 29, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 24, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
added a commit
that referenced
this issue
Oct 24, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
Yuval-Ariel
pushed a commit
that referenced
this issue
Nov 23, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
Yuval-Ariel
pushed a commit
that referenced
this issue
Nov 25, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
Yuval-Ariel
pushed a commit
that referenced
this issue
Apr 30, 2023
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
Yuval-Ariel
pushed a commit
that referenced
this issue
May 4, 2023
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
udi-speedb
pushed a commit
that referenced
this issue
Nov 13, 2023
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
udi-speedb
pushed a commit
that referenced
this issue
Dec 3, 2023
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the Makefile regenerates
make_config.mkon every invocation, which takes a long time and causes a make restart. This breaks shell tab-completion in a way that kills the shell's readline functionality.Avoid this by regenerating only when invoked for actual recipe run (this can be easily identified by checking for the existence of
norqin theMAKEFLAGSvariable, which stand for--dry-runand--question, respectively, both of which don't execute recipes) or in casemake_config.mkdoesn't exist (this is needed since some targets are conditionally defined based on values defined inmake_config.mk).The text was updated successfully, but these errors were encountered: