makefile: fix shell tab-completions (#147) #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-io
force-pushed
the
147-makefile-tab-completion-is-broken
branch
from
9997130 to
0917ff5
Compare
Yuval-Ariel
approved these changes
Sep 23, 2022
isaac-io
force-pushed
the
147-makefile-tab-completion-is-broken
branch
2 times, most recently
from
276be33 to
04d8ae8
Compare
Yuval-Ariel
approved these changes
Sep 25, 2022
Shell tab-completions are currently broken due to the regeneration of `make_config.mk` on every invocation, which also causes a make restart. Prevent regeneration if the file exists and we're in an invocation that doesn't execute rule recipes (-n or -q).
isaac-io
force-pushed
the
147-makefile-tab-completion-is-broken
branch
from
04d8ae8 to
fd19de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell tab-completions are currently broken due to the regeneration of
make_config.mkon every invocation, which also causes a make restart.Prevent regeneration if the file exists and we're in an invocation that
doesn't execute rule recipes (-n or -q).