-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db_bench: many default values are not the default in Speedb #61
Comments
changes: |
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
Seems the rocksdb default are better then the db_bench defaults |
@erez-speedb , what do you mean outlier? the trend looks completely different |
Running the small db test again Passed perf tests. |
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
actual values that have changed: 1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators) 2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb 3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb) 4. enable_pipelined_write - from true to false
these params are:
table_cache_numshardbits is 4 while default is 6.
new table reader for comp inputs
block cache 8mb
index shortening mode
enable_pipelined_write - true in db bench and false otherwise.
delayed_write_rate = 8Mb and default value is 0.
and possibly more.
fix by making db_bench take the default value
The text was updated successfully, but these errors were encountered: