Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_bench: set db_bench defaults to speedbs (#61) #322

Conversation

Yuval-Ariel
Copy link
Contributor

actual values that have changed:

  1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators)
  2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb
  3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb)
  4. enable_pipelined_write - from true to false

actual values that have changed:
1. index_shortening_mode - from 2 (kShortenSeparatorsAndSuccessor) to 1 (kShortenSeparators)
2. hard_pending_compaction_bytes_limit - from 128 Gb to 256 Gb
3. delayed_write_rate - from 8Mb to 0 (0 is sanitized to 16Mb)
4. enable_pipelined_write - from true to false
@Yuval-Ariel Yuval-Ariel requested a review from ayulas January 1, 2023 09:55
@Yuval-Ariel Yuval-Ariel self-assigned this Jan 1, 2023
@Yuval-Ariel Yuval-Ariel linked an issue Jan 1, 2023 that may be closed by this pull request
@Yuval-Ariel
Copy link
Contributor Author

@erez-speedb plz check

Copy link
Contributor

@ayulas ayulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls note that now the enable_pipelined_write is flase and it might change the base result

@Yuval-Ariel Yuval-Ariel merged commit fa31dd3 into main Jan 18, 2023
@Yuval-Ariel Yuval-Ariel deleted the 61-db_bench-many-default-values-are-not-the-default-in-speedb branch February 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db_bench: many default values are not the default in Speedb
2 participants