Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "pattern" category #492

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add "pattern" category #492

merged 1 commit into from
Jan 8, 2025

Conversation

spenserblack
Copy link
Owner

Used for Regex and ABNF.

@spenserblack spenserblack added the semver-minor This pull request bumps the minor version label Jan 8, 2025
@spenserblack spenserblack requested a review from o2sh as a code owner January 8, 2025 19:10
@spenserblack spenserblack linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (bf5ca9f) to head (759944a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gengo/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          18       18           
  Lines         516      516           
=======================================
  Hits          367      367           
  Misses        149      149           
Flag Coverage Δ
--no-default-features 72.52% <0.00%> (ø)
--no-default-features --features color 70.73% <0.00%> (ø)
ubuntu-latest 71.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Used for Regex and ABNF.
@spenserblack spenserblack force-pushed the feature/85/pattern-category branch from 9f20abe to 759944a Compare January 8, 2025 19:27
@spenserblack spenserblack merged commit c7395d0 into main Jan 8, 2025
20 of 21 checks passed
@spenserblack spenserblack deleted the feature/85/pattern-category branch January 8, 2025 19:37
@spenserblack
Copy link
Owner Author

@o2sh Would you want to be removed from the CODEOWNERS entry? I don't want to keep spamming you with review requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor This pull request bumps the minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pattern category for ABNF, Regex, etc.
1 participant