Revert previous fullPath changes - add tests for nested BasePaths #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm okay, but what will be the right long term solution? |
|
Well the original code is actually perfect because it works as expected with "nested" BasePaths on all methods ( My problem is that I needed a solution to obtain the full path. Because in my case I write files to a location (using a BasePathFs that got built up in stages so they are nested). Then it must send the "full path" to an external service. But the solution is perhaps the pull request 83 (#83) I created? It adds a utility method What is your take on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the previous
fullPathchanges and add tests for "nested"BasePath's