Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FullBaseFsPath utility method #83

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Add FullBaseFsPath utility method #83

merged 1 commit into from
Apr 20, 2016

Conversation

francoishill
Copy link
Contributor

This method resolves the "Full" path of the BasePathFs. It also resolves for nested BasePaths.
Unit tests were also added

This method resolves the "Full" path of the `BasePathFs`. It also resolves for nested BasePaths.
Unit tests were also added
@mbertschler
Copy link
Collaborator

as a reply on:

francoishill commented an hour ago:
Well the original code is actually perfect because it works as expected with "nested" BasePaths on all methods (MkdirAll, Create, etc) except the RealPath. So for "interacting" with the nested file system it acts on the correct/nested files/folders.

My problem is that I needed a solution to obtain the full path. Because in my case I write files to a location (using a BasePathFs that got built up in stages so they are nested). Then it must send the "full path" to an external service.

But the solution is perhaps the pull request 83 (#83) I created? It adds a utility method FullBaseFsPath to resolve full paths of possible "nested" base paths.

What is your take on this?

The only concern would be the security concern that was mentioned before, about not revealing paths to the user, but I could not come up with an idea where this would be relevant.

So I welcome this new function.

@mbertschler mbertschler merged commit 5dbffb6 into spf13:master Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants