add link-local IP to veth0 for istio #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
commented
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3588 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 50 50
Lines 4391 4391
=======================================
Hits 3564 3564
Misses 670 670
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. |
cyclinder
force-pushed
the
coordinator/veth_address
branch
from
2aef736
to
8037103
Compare
weizhoublue
reviewed
Jun 18, 2024
cyclinder
force-pushed
the
coordinator/veth_address
branch
from
8037103
to
3d36f77
Compare
|
cherry pick ? |
weizhoublue
added
cherrypick-release-v0.8
|
@ty-dc CI failed, is it caused by the upgrade CI ? |
no rebase main |
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
coordinator/veth_address
branch
from
3d36f77
to
b91c9dd
Compare
weizhoublue
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
coordinator: add ipAddress for pod's veth0 Signed-off-by: robot <tao.yang@daocloud.io>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
coordinator: add ipAddress for pod's veth0 Signed-off-by: robot <tao.yang@daocloud.io>
ty-dc
pushed a commit
to ty-dc/spiderpool
that referenced
this pull request
Jun 23, 2024
…address coordinator: add ipAddress for pod's veth0 Signed-off-by: robot <tao.yang@daocloud.io>
ty-dc
pushed a commit
that referenced
this pull request
Jun 24, 2024
Signed-off-by: tao.yang <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
The iptables redirect module uses the IP address of the incoming interface as the dst to modify the packet, but if the interface is not configured with an IP address, the packet will be dropped.
NOTE: this is for istio sidecar
Which issue(s) this PR fixes:
Fixes #3568
Special notes for your reviewer: