Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link-local IP to veth0 for istio #3623

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

weizhoublue
Copy link
Collaborator

robot cherry pick PR #3588 from cyclinder,to branch release-v0.9, action https://github.com/spidernet-io/spiderpool/actions/runs/9609000879 , commits 13c95f0

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (f4809e8) to head (d7fa0e4).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-v0.9    #3623   +/-   ##
=============================================
  Coverage         81.48%   81.48%           
=============================================
  Files                50       50           
  Lines              4338     4338           
=============================================
  Hits               3535     3535           
  Misses              641      641           
  Partials            162      162           
Flag Coverage Δ
unittests 81.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@weizhoublue
Copy link
Collaborator Author

@ty-dc ci

@ty-dc
Copy link
Collaborator

ty-dc commented Jun 21, 2024

The code merged into release-v0.9 triggers the pull_request_target to use the image of the main branch.

@weizhoublue
Copy link
Collaborator Author

weizhoublue commented Jun 23, 2024

https://github.com/spidernet-io/spiderpool/actions/runs/9609003755/job/26502881762?pr=3623

encountered an failed case never happened

     fail to run a pod when IP resource of an ippool is exhausted and an IP who is set in excludeIPs field of ippool, should not be assigned to a pod [E00008, S00002]

Signed-off-by: tao.yang <tao.yang@daocloud.io>
@ty-dc ty-dc force-pushed the robot/cherrypick/pr3588/release-v0.9 branch from af06674 to d7fa0e4 Compare June 24, 2024 02:06
@ty-dc
Copy link
Collaborator

ty-dc commented Jun 24, 2024

Warning  FailedCreatePodSandBox  4m38s (x17 over 8m8s)  kubelet            (combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "915253528605f96a4db27301569495040e6e5bfd93e55e643aff6b04711acd4e": plugin type="multus" name="multus-cni-network" failed (add): [ns187-858559962/deploy187-858549683-5b4569f6dc-qrqk7/7a54422a-5a39-4650-8e1d-07d5d67ab318:macvlan-vlan0]: error adding container to network "macvlan-vlan0": spiderpool IP allocation error: [POST /ipam/ip][500] postIpamIpFailure  failed to allocate IP addresses in standard mode: it's invalid to use 'ipam.spidernet.io/subnets' or 'ipam.spidernet.io/subnet' annotation when Auto-Pool feature is disabled

The upgrade-ci command in cherry-pick fails due to an image usage error.

Now, I rebase release-v0.9, and we will observe CI later.

@weizhoublue weizhoublue merged commit 704f6f3 into release-v0.9 Jun 24, 2024
48 of 49 checks passed
@weizhoublue weizhoublue deleted the robot/cherrypick/pr3588/release-v0.9 branch June 24, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants