Fix typo ClusterSPIFFEID for workloadTSelectoremplates #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattias Gees <mattias.gees@jetstack.io>
MattiasGees
requested review from
marcofranssen,
kfox1111,
dfeldman,
faisal-memon and
mrsabath
as code owners
kfox1111
approved these changes
Nov 16, 2023
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Nov 30, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Dec 1, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com> Co-authored-by: kfox1111 <Kevin.Fox@pnnl.gov>
marcofranssen
added a commit
that referenced
this pull request
Dec 1, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com> Co-authored-by: kfox1111 <Kevin.Fox@pnnl.gov>
marcofranssen
added a commit
that referenced
this pull request
Dec 1, 2023
* b7d8590 Fix missing protocol in JWT Issuer (#120) * 1ef207c Add note about supported version upgrades (#119) * 4281114 Fix missing release name from install documentation (#118) * e030fa1 Allow additional CRs to be managed by the chart (#117) * d936293 Enable agent to kubelet connection to use hostname (#112) * e68f617 Bump test chart dependencies (#116) * d616632 Bump spire version to 1.8.5 (#115) * 95e1eb7 Bump test chart dependencies * 966061c Auto add default CSIDriver labels on OpenShift * c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110) * 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107) * 5c0ce97 Ordering of SecurityContextConstraint array items (#105) * 889d0af Bump test chart dependencies * f5d1376 Documentation cleanup (#97) Signed-off-by: Marco Franssen <marco.franssen@gmail.com> Co-authored-by: kfox1111 <Kevin.Fox@pnnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a small typo in the ClusterSPIFFEID spec and this small change will fix it.