Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional CRs to be managed by the chart #117

Merged
merged 66 commits into from
Nov 28, 2023
Merged

Allow additional CRs to be managed by the chart #117

merged 66 commits into from
Nov 28, 2023

Conversation

kfox1111
Copy link
Collaborator

Sometimes additional ClusterSPIFFEIDs and the other CRs are needed. Add support for the end user to manage those extra CRs via the chart.

kfox1111 and others added 30 commits October 25, 2023 12:47
@kfox1111
Add support for the new spire-controller-manager class feature
9fe0bd9 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix docs. Swich nested deployment to use controller manager
ef589a9 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Incorperate feedback
91c49f5 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into controller-manager-class
eff2e04 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Test with nightly
7f195fb 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix global object naming clash
cdf6e14 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix missing dot
690ff7e 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix naming conflict with cluster ids
fb01de4 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix scoping issue
d683f5f 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix typo
1e30d9e 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix webhook name collision
0ddc76b 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix webhook reference and add note to user about className
85a12a9 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Upgrade has to work on the old version of the object before rename
93ff943 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix formatting
b8d276b 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Remove extra junk from job
f7466a4 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Easier local runs and wait for crds
3db9a0c 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Add missing crd upgrade
6ce33bc 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into controller-manager-class
04a02cb 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Update upgrade notes
17283dd 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111 @marcofranssen
Update charts/spire/charts/spire-server/templates/controller-manager-…
51599c3 
…cluster-ids.yaml

Co-authored-by: Marco Franssen <marco.franssen@gmail.com>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Incorperate feedback
7aac57c 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into controller-manager-class
74388e3 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Bump version to the released 0.4.0
d4f6d45 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into controller-manager-class
d344095
@kfox1111
Fix docs
80036b6 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge in crd changes from upstream
1fff86d 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Add auto populate dns
8bbd20a 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into controller-manager-class
48b7644
@kfox1111
Merge branch 'main' into controller-manager-class
3e9c053
@kfox1111 @faisal-memon
Update charts/spire/README.md
a009101 
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111 @faisal-memon
Apply suggestions from code review
835ccb2 
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
kfox1111 and others added 2 commits November 27, 2023 16:47
@kfox1111 @faisal-memon
Apply suggestions from code review
5836bdb 
Co-authored-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Fix docs
7844b23 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Remove dead code
f694ff7 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Fix extra newline
759b15b 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Incorperate feedback
f3c6f55 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into extra-crs
b0ed1ab
faisal-memon
faisal-memon approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@faisal-memon faisal-memon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kfox1111 for making the requested changes.

@faisal-memon faisal-memon merged commit e030fa1 into main Nov 28, 2023
47 checks passed
@faisal-memon faisal-memon deleted the extra-crs branch November 28, 2023 17:15
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
e6ee0ea 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
8a7108f 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
f9f6864 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
f2a7cca 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
435deea 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
7b28c06 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
@marcofranssen marcofranssen mentioned this pull request Nov 30, 2023
Merged
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
82950af 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Nov 30, 2023
@marcofranssen
Bump spire Helm Chart version from 0.15.1 to 0.16.0
d4b3666 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Dec 1, 2023
@marcofranssen @kfox1111
Bump spire Helm Chart version from 0.15.1 to 0.16.0
3301a4f 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Co-authored-by: kfox1111 <Kevin.Fox@pnnl.gov>
marcofranssen added a commit that referenced this pull request Dec 1, 2023
@marcofranssen @kfox1111
Bump spire Helm Chart version from 0.15.1 to 0.16.0
4d7939b 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Co-authored-by: kfox1111 <Kevin.Fox@pnnl.gov>
marcofranssen added a commit that referenced this pull request Dec 1, 2023
@marcofranssen @kfox1111
Bump spire Helm Chart version from 0.15.1 to 0.16.0
78bb95b 
* b7d8590 Fix missing protocol in JWT Issuer  (#120)
* 1ef207c Add note about supported version upgrades (#119)
* 4281114 Fix missing release name from install documentation (#118)
* e030fa1 Allow additional CRs to be managed by the chart (#117)
* d936293 Enable agent to kubelet connection to use hostname (#112)
* e68f617 Bump test chart dependencies (#116)
* d616632 Bump spire version to 1.8.5 (#115)
* 95e1eb7 Bump test chart dependencies
* 966061c Auto add default CSIDriver labels on OpenShift
* c9885de Introduce ReadOnlyRootFilesystem for Tornjak frontend (#110)
* 8107095 Fix typo ClusterSPIFFEID for workloadTSelectoremplates (#107)
* 5c0ce97 Ordering of SecurityContextConstraint array items (#105)
* 889d0af Bump test chart dependencies
* f5d1376 Documentation cleanup (#97)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>

Co-authored-by: kfox1111 <Kevin.Fox@pnnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-memon faisal-memon faisal-memon approved these changes

@marcofranssen marcofranssen Awaiting requested review from marcofranssen marcofranssen is a code owner

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kfox1111 @marcofranssen @faisal-memon