-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IBM s390x multi arch support #3967
Conversation
/retest |
Hi @Basavaraju-G! While this change itself is small, it has bigger maintenance and support implications. ARM support was recently introduced due to growing demand, however along with that was also a lot of conversation and work around how to test/build/ship an ARM flavored SPIRE. Choosing to support a new architecture is unfortunately not a decision we can easily make .. if there is sufficient demand, and we have a good way to run tests and build artifacts on that platform, then it's certainly something we're open to discussing ... that said, we haven't been asked for s390x before (as far as I know), and we don't see a clear path forward right now for test and build |
Hi @evan2645, thank you for your review. Thanks |
Would you be able to provide an account and free credits for the project to test and build on? I think we'd also want someone on the hook to fix the build there if it ever breaks .. the added overhead is expensive for SPIRE maintainers. The project is (in general) willing to accept such overhead if there is substantial community need, but this is the first time we have a request to support this architecture. I feel that the lowest friction path forward is to maintain a light fork and build + ship this flavor of SPIRE independently |
Hi @evan2645, In addition to the before mentioned IBM Public Cloud zVPC machines, there is the IBM LinuxOne Community Cloud which is intended for development and testing, mainly for OpenSource projects or education. You can register as a project there and once approved should be able to access a Z Linux Virtual Server. |
Thanks for pointing that out @olira We again discussed this PR in the contributor sync call yesterday, and the consensus was that we're happy to take changes to the makefile that support building on s390x without forking the project, but we can't commit to shipping support for s390x in our artifacts until a number of other things are figured out. So, I think there are two paths forward:
OR
|
Hi @evan2645 thank for you suggestion. we are okay with first option. i will remove platform changes as suggested. for second option we have dependency of github runner support on s390x platform actions/runner#2264. We are working on this to support. once we have this support will open an issue and discuss official support matrix for s390x. Thanks. |
6891292
to
08c1639
Compare
Thank you @Basavaraju-G , this looks good. Can you please force push this PR with a DCO set on the commit(s)? We will merge it as soon as the DCO is signed |
Hi again @Basavaraju-G .. we're ready to take this change but need the DCO to be signed off first. Mind force pushing this branch with the DCO set on your commits? You'll need to rewrite them with |
08c1639
to
15ad80c
Compare
Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/sdk/azidentity/v1.2.2/CHANGELOG.md) - [Commits](Azure/azure-sdk-for-go@sdk/azidentity/v1.2.1...sdk/azidentity/v1.2.2) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.2 to 1.5.3. - [Release notes](https://github.com/golang/protobuf/releases) - [Commits](golang/protobuf@v1.5.2...v1.5.3) --- updated-dependencies: - dependency-name: github.com/golang/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/aws/aws-sdk-go-v2/service/secretsmanager](https://github.com/aws/aws-sdk-go-v2) from 1.18.0 to 1.19.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.18.0...service/s3/v1.19.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/secretsmanager dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
* Bump google.golang.org/protobuf from 1.28.1 to 1.29.0 Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.28.1 to 1.29.0. - [Release notes](https://github.com/protocolbuffers/protobuf-go/releases) - [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash) - [Commits](protocolbuffers/protobuf-go@v1.28.1...v1.29.0) --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add generated protobuf files Signed-off-by: Ryan Turner <turner@uber.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Turner <turner@uber.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan Turner <turner@uber.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
* Add mint and revoke scaffolding to datastore layer and apply changes to common.Bundle to persist tainted keys Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
* Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.29.0 to 1.29.1. - [Release notes](https://github.com/protocolbuffers/protobuf-go/releases) - [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash) - [Commits](protocolbuffers/protobuf-go@v1.29.0...v1.29.1) --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update .pb.go files Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
* Move CA rotation and CA manage out of ca package Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * Add test for ca manager Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * cover new functions to manager.go Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * more test Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * some cleanup Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * resolve endpoint test Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * Add coverage Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * Verify if upstream authority is set before closing Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * rename packages and solve some typos Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> * PR changes Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> --------- Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
…ffe#3941) * Create function for cleaning stale node resolver entries at database initialization Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> * Add todo for removing the created function in future releases Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> * Improve cleanup test by initializing the database again during test Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> * Fix lint issues Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> * Update todo comment to fix a release for removal Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> * Simplify query Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> * Fix Lint Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> --------- Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> Co-authored-by: Andrew Harding <azdagron@gmail.com> Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.4.1 to 2.5.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@f03ac48...4b4e9c3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
* Implement TaintJWTKey in datastore Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
* Implement TaintX509CA on datastore Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
) Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.50.2 to 0.51.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.50.2...v0.51.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.2+incompatible to 23.0.3+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v23.0.2...v23.0.3) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
… a Go installation (spiffe#4055) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
…piffe#4060) Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.91.0 to 1.93.1. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.91.0...service/ec2/v1.93.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.23.2 to 3.23.3. - [Release notes](https://github.com/shirou/gopsutil/releases) - [Commits](shirou/gopsutil@v3.23.2...v3.23.3) --- updated-dependencies: - dependency-name: github.com/shirou/gopsutil/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.114.0 to 0.117.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.114.0...v0.117.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [cloud.google.com/go/iam](https://github.com/googleapis/google-cloud-go) from 0.13.0 to 1.0.0. - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@v0.13.0...dlp/v1.0.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/iam dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@c3667d9...9e9de22) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
The MAINTAINERS.md file has become quite large over time, mostly due to refinements in the release process. Understanding the details of the release process are not particularly relevant to understanding the core duties of a project maintainer, which is the purpose of the MAINTAINERS.md file. Similarly, maintainers who need to execute the release process are not concerned with the general documentation about what it means to be a maintainer on the project. For these reasons, move the existing release process documentation as is to a new file in the repository, and reference the new documentation in MAINTAINERS.md for traceability. Signed-off-by: Ryan Turner <turner@uber.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Use go spiffe types server unit Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/google/go-tpm-tools](https://github.com/google/go-tpm-tools) from 0.3.10 to 0.3.11. - [Release notes](https://github.com/google/go-tpm-tools/releases) - [Commits](google/go-tpm-tools@v0.3.10...v0.3.11) --- updated-dependencies: - dependency-name: github.com/google/go-tpm-tools dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [cloud.google.com/go/kms](https://github.com/googleapis/google-cloud-go) from 1.10.0 to 1.10.1. - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/documentai/CHANGES.md) - [Commits](googleapis/google-cloud-go@kms/v1.10.0...kms/v1.10.1) --- updated-dependencies: - dependency-name: cloud.google.com/go/kms dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
v5.0.0 has no changes since v4.4.0 except to support Go modules. Migrate to it so we can get PR bumps generated by dependabot since it is a major version bump. Signed-off-by: Ryan Turner <turner@uber.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
…spiffe#4067) Bumps [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.4.0...sdk/azcore/v1.5.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.8.1 to 0.9.0. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.8.1...v0.9.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
…lename (spiffe#4062) * Fixes spiffe#2247 - checksum algorithm in release pakdage artifact filename Signed-off-by: Edwin Buck <edwbuck@gmail.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Add hint field delegated identity API Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.117.0 to 0.118.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.117.0...v0.118.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
…e#4079) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
15ad80c
to
72679f8
Compare
This PR will add s390x multi arch support.
Pull Request check list
[x] Commit conforms to CONTRIBUTING.md?
Affected functionality
No existing functionality affected. New Arch support is added
Description of change.
As of now, spire works on amd64 and arm64 platform. This PR will add support for s390x platform.
Signed-off-by: Basavaraju G basavaraju013@gmail.com