update templates to componentize-py #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
itowlson
reviewed
Jan 29, 2024
|
updated to incorporate the suggestions. |
itowlson
reviewed
Feb 13, 2024
templates/http-py/content/app.py
Outdated
| return Response(200, | ||
| {"content-type": "text/plain"}, | ||
| bytes(f"Hello from the Python SDK", "utf-8")) | ||
| class IncomingHandler(simple.IncomingHandler): |
There was a problem hiding this comment.
I thought we exterminated simple or did I misunderstand?
There was a problem hiding this comment.
oh yes - I forgot to update this. I will fix it.
There was a problem hiding this comment.
fixed it! Although will need to update the version of the SDK once we have a new RC published.
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
componentize_template
branch
from
03c6c40 to
cb0b67d
Compare
itowlson
approved these changes
Feb 13, 2024
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update templates to be used with componentize-py