Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python tests to use componentize-py template #2275

Merged
merged 2 commits into from
Feb 14, 2024
Merged

update python tests to use componentize-py template #2275

merged 2 commits into from
Feb 14, 2024

Conversation

karthik2804
Copy link
Contributor

Updated the test based on the latest update based on spinframework/spin-python-sdk#66

Also, updates the testing readme to include information about running all the tests.

rylev
rylev approved these changes Feb 14, 2024
View reviewed changes
@karthik2804 karthik2804 force-pushed the update_py_test branch 5 times, most recently from 8f0aad5 to 31d19ca Compare February 14, 2024 21:01
dicej
dicej reviewed Feb 14, 2024
View reviewed changes
@itowlson itowlson changed the title update pyton tests to use componentize-py template update python tests to use componentize-py template Feb 14, 2024
@karthik2804
update pyton tests to use componentize-py template
2863fdb 
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
@karthik2804 karthik2804 force-pushed the update_py_test branch 4 times, most recently from 3da2f43 to 912427c Compare February 14, 2024 22:35
@karthik2804
Copy link
Contributor Author

seem to be running into an unrelated failure

failures:
    integration_tests::test_vault_config_provider
test result: FAILED. 36 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 371.07s

@karthik2804
update spin-sdk version in requirements.txt
ce06e7d 
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
@karthik2804 karthik2804 merged commit 8967f6e into spinframework:main Feb 14, 2024
11 checks passed
@karthik2804 karthik2804 deleted the update_py_test branch February 14, 2024 23:25
@melissaklein24 melissaklein24 added this to the Spin 2.3 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicej dicej dicej left review comments

@itowlson itowlson itowlson approved these changes

@rylev rylev rylev approved these changes

@rajatjindal rajatjindal Awaiting requested review from rajatjindal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spin 2.3
Development

Successfully merging this pull request may close these issues.
5 participants
@karthik2804 @itowlson @dicej @rylev @melissaklein24